From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jakub@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id C66A0385781A
 for <dwz@sourceware.org>; Wed, 17 Mar 2021 13:18:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C66A0385781A
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-575-msAaqXwBNgq1Mp_XuCJ3RA-1; Wed, 17 Mar 2021 09:18:08 -0400
X-MC-Unique: msAaqXwBNgq1Mp_XuCJ3RA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38D931007467;
 Wed, 17 Mar 2021 13:18:07 +0000 (UTC)
Received: from tucnak.zalov.cz (ovpn-112-34.ams2.redhat.com [10.36.112.34])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C12AE60853;
 Wed, 17 Mar 2021 13:18:06 +0000 (UTC)
Received: from tucnak.zalov.cz (localhost [127.0.0.1])
 by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 12HDI33p136747
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
 Wed, 17 Mar 2021 14:18:04 +0100
Received: (from jakub@localhost)
 by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 12HDI2gA136746;
 Wed, 17 Mar 2021 14:18:02 +0100
Date: Wed, 17 Mar 2021 14:18:02 +0100
From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, mark@klomp.org
Subject: Re: [committed] Make main more readable
Message-ID: <20210317131802.GG231854@tucnak>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20210317131444.GA11885@delia>
MIME-Version: 1.0
In-Reply-To: <20210317131444.GA11885@delia>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2021 13:18:12 -0000

On Wed, Mar 17, 2021 at 02:14:45PM +0100, Tom de Vries wrote:
> @@ -17048,10 +17050,12 @@ main (int argc, char *argv[])
>    outfile = NULL;
>    hardlink = false;
>    parse_args (argc, argv, &hardlink, &outfile);
> +  nr_files = argc - optind;
> +  files = (const char **)&argv[optind];
>  
> -  if (optind == argc || optind + 1 == argc)
> +  if (nr_files <= 1)
>      {
> -      const char *file = optind == argc ? "a.out" : argv[optind];
> +      const char *file = nr_files == 0 ? "a.out" : files[0];

Isn't that aliasing violation?

	Jakub