public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com, mark@klomp.org
Subject: [committed][testsuite] Remove smaller-than.sh test in pr24747.sh
Date: Mon, 22 Mar 2021 06:13:57 +0100	[thread overview]
Message-ID: <20210322051356.GA821@delia> (raw)

Hi,

As reported in PR27603, when using clang-11 we run into:
...
Running testsuite/dwz.tests/dwz-tests.exp ...
+ exec=start-gold
+ cp start-gold 1
+ dwz 1
+ smaller-than.sh 1 start-gold
FAIL: testsuite/dwz.tests/pr24747.sh
...

The FAIL as such has been fixed by commit b3c99ab "Make smaller-than.sh match
dwz heuristic", but the only reason that dwz manages to optimize something is
because the dwarf producer is lazy and doesn't generate minimal encodings.

We cannot assume that the dwarf producer is lazy, so remove the
smaller-than.sh test.

Committed to trunk.

Thanks,
- Tom

[testsuite] Remove smaller-than.sh test in pr24747.sh

2021-03-22  Tom de Vries  <tdevries@suse.de>

	PR dwz/27603
	* testsuite/dwz.tests/pr24747.sh: Remove smaller-than.sh test.

---
 testsuite/dwz.tests/pr24747.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testsuite/dwz.tests/pr24747.sh b/testsuite/dwz.tests/pr24747.sh
index f868dbe..7182f72 100644
--- a/testsuite/dwz.tests/pr24747.sh
+++ b/testsuite/dwz.tests/pr24747.sh
@@ -4,6 +4,4 @@ cp $exec 1
 
 dwz 1
 
-smaller-than.sh 1 $exec
-
 rm -f 1

                 reply	other threads:[~2021-03-22  5:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322051356.GA821@delia \
    --to=tdevries@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).