From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 3A56B3858002 for ; Wed, 24 Mar 2021 09:10:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A56B3858002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 59CF2AC16; Wed, 24 Mar 2021 09:10:31 +0000 (UTC) Date: Wed, 24 Mar 2021 10:10:29 +0100 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com, mark@klomp.org Subject: [committed][testsuite] Show error output in twice-multifile.sh Message-ID: <20210324091028.GA31916@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 09:10:33 -0000 Hi, When building dwz with -fsanitize=address, we get: ... $ make check RUNTESTFLAGS=dwz-tests.exp=twice-multifile.sh Running src/testsuite/dwz.tests/dwz-tests.exp ... child process exited abnormally FAIL: src/testsuite/dwz.tests/twice-multifile.sh ... The test-case fails because "dwz -m 3 1 2" returns 1, but we don't see why because the error output is redirected to dwz.err. Fix this by dumping dwz.err if "dwz -m 3 1 2" status is not zero. Committed to trunk. Thanks, - Tom [testsuite] Show error output in twice-multifile.sh 2021-03-24 Tom de Vries * testsuite/dwz.tests/twice-multifile.sh: Dump dwz.err if dwz status is not 0. --- testsuite/dwz.tests/twice-multifile.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/testsuite/dwz.tests/twice-multifile.sh b/testsuite/dwz.tests/twice-multifile.sh index 8a66e25..1ff0166 100644 --- a/testsuite/dwz.tests/twice-multifile.sh +++ b/testsuite/dwz.tests/twice-multifile.sh @@ -24,7 +24,10 @@ if [ $(grep -qv "DWARF compression not beneficial" dwz.err \ exit 1 fi -[ $status -eq 0 ] +if [ $status -ne 0 ]; then + cat dwz.err + exit 1 +fi smaller-than.sh 1 1.saved