Buildbot failure in Wildebeest Builder on whole buildset

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/23/builds/311

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-amd64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Fwd: Buildbot failure in Wildebeest Builder on whole buildset

[Tom de Vries]

Hi Mark,

I've just committed patch "Move hardlink handling out of dwz function"
and there's this buildbot failure.

Is there something easy that you can do to find out if this is a fluke
or not, f.i. retry the build for that bot?

Thanks,
- Tom


-------- Forwarded Message --------
Subject: Buildbot failure in Wildebeest Builder on whole buildset
Date: Thu, 25 Mar 2021 08:41:56 +0000
From: buildbot@builder.wildebeest.org
To: dwz@sourceware.org

The Buildbot has detected a failed build on builder whole buildset while
building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/23/builds/311

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-amd64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Re: Fwd: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

Hi Tom,

On Thu, 2021-03-25 at 09:50 +0100, Tom de Vries wrote:
> I've just committed patch "Move hardlink handling out of dwz
> function"
> and there's this buildbot failure.
> 
> Is there something easy that you can do to find out if this is a
> fluke
> or not, f.i. retry the build for that bot?

I logged into the buildbot worker and did a dwz build myself.
make check does produce 32 unexpected failures.
Removing the last commit makes everything pass.
Adding the commit again produces the failures again.
It isn't a fluke.

The problem is simply that:
cp hello 1
dwz 1

Makes dwz produce an exit code of 1 which seems to be interpreted as
child process exited abnormally in a make check run.

running under valgrind --track-origins=yes gives:

==31313== Conditional jump or move depends on uninitialised value(s)
==31313==    at 0x127974: dwz (dwz.c:15287)
==31313==    by 0x10BB7C: dwz_with_low_mem (dwz.c:16227)
==31313==    by 0x10BB7C: dwz_one_file (dwz.c:16253)
==31313==    by 0x10BB7C: main (dwz.c:16532)
==31313==  Uninitialised value was created by a stack allocation
==31313==    at 0x10B59B: main (dwz.c:16513)

I haven't tracked down what res->res precisely depends on that doesn't
have a defined value.

Cheers,

Mark

Re: Fwd: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

Hi Tom,

On Thu, 2021-03-25 at 11:41 +0100, Mark Wielaard wrote:
> On Thu, 2021-03-25 at 09:50 +0100, Tom de Vries wrote:
> > I've just committed patch "Move hardlink handling out of dwz
> > function"
> > and there's this buildbot failure.
> > 
> > Is there something easy that you can do to find out if this is a
> > fluke
> > or not, f.i. retry the build for that bot?
> 
> I logged into the buildbot worker and did a dwz build myself.
> make check does produce 32 unexpected failures.
> Removing the last commit makes everything pass.
> Adding the commit again produces the failures again.
> It isn't a fluke.
> 
> The problem is simply that:
> cp hello 1
> dwz 1
> 
> Makes dwz produce an exit code of 1 which seems to be interpreted as
> child process exited abnormally in a make check run.
> 
> running under valgrind --track-origins=yes gives:
> 
> ==31313== Conditional jump or move depends on uninitialised value(s)
> ==31313==    at 0x127974: dwz (dwz.c:15287)
> ==31313==    by 0x10BB7C: dwz_with_low_mem (dwz.c:16227)
> ==31313==    by 0x10BB7C: dwz_one_file (dwz.c:16253)
> ==31313==    by 0x10BB7C: main (dwz.c:16532)
> ==31313==  Uninitialised value was created by a stack allocation
> ==31313==    at 0x10B59B: main (dwz.c:16513)
> 
> I haven't tracked down what res->res precisely depends on that
> doesn't
> have a defined value.

Note that dwz_one_file was inlined into main, causing valgrind to
pinpoint the wrong frame. Without inlining we get:

==2502== Conditional jump or move depends on uninitialised value(s)
==2502==    at 0x13CF4F: dwz (dwz.c:15287)
==2502==    by 0x13FE3A: dwz_with_low_mem (dwz.c:16227)
==2502==    by 0x13FEAE: dwz_one_file (dwz.c:16253)
==2502==    by 0x140B59: main (dwz.c:16532)
==2502==  Uninitialised value was created by a stack allocation
==2502==    at 0x13FE7F: dwz_one_file (dwz.c:16245)

And indeed we see:

static int
dwz_one_file (const char *file, const char *outfile)
{
  struct file_result res;

  if (stats_p)
    init_stats (file);

  res.die_count = 0;

  return dwz_with_low_mem (file, outfile, &res, NULL);
}

Defines and passes down res, but only initializes the die_count field.

Then in dwz_with_low_mem we simply pass that res to dwz:

  ret = (low_mem_die_limit == 0
         ? 2
         : dwz (file, outfile, res));

And in dwz the first thing we do is:

  if (res->res == -1)
    return 1;

But res->res was never given a value and so could be anything.

Cheers,

Mark

Re: Fwd: Buildbot failure in Wildebeest Builder on whole buildset

[Tom de Vries]

On 3/25/21 11:49 AM, Mark Wielaard wrote:
> Hi Tom,
> 
> On Thu, 2021-03-25 at 11:41 +0100, Mark Wielaard wrote:
>> On Thu, 2021-03-25 at 09:50 +0100, Tom de Vries wrote:
>>> I've just committed patch "Move hardlink handling out of dwz
>>> function"
>>> and there's this buildbot failure.
>>>
>>> Is there something easy that you can do to find out if this is a
>>> fluke
>>> or not, f.i. retry the build for that bot?
>>
>> I logged into the buildbot worker and did a dwz build myself.
>> make check does produce 32 unexpected failures.
>> Removing the last commit makes everything pass.
>> Adding the commit again produces the failures again.
>> It isn't a fluke.
>>
>> The problem is simply that:
>> cp hello 1
>> dwz 1
>>
>> Makes dwz produce an exit code of 1 which seems to be interpreted as
>> child process exited abnormally in a make check run.
>>
>> running under valgrind --track-origins=yes gives:
>>
>> ==31313== Conditional jump or move depends on uninitialised value(s)
>> ==31313==    at 0x127974: dwz (dwz.c:15287)
>> ==31313==    by 0x10BB7C: dwz_with_low_mem (dwz.c:16227)
>> ==31313==    by 0x10BB7C: dwz_one_file (dwz.c:16253)
>> ==31313==    by 0x10BB7C: main (dwz.c:16532)
>> ==31313==  Uninitialised value was created by a stack allocation
>> ==31313==    at 0x10B59B: main (dwz.c:16513)
>>
>> I haven't tracked down what res->res precisely depends on that
>> doesn't
>> have a defined value.
> 
> Note that dwz_one_file was inlined into main, causing valgrind to
> pinpoint the wrong frame. Without inlining we get:
> 
> ==2502== Conditional jump or move depends on uninitialised value(s)
> ==2502==    at 0x13CF4F: dwz (dwz.c:15287)
> ==2502==    by 0x13FE3A: dwz_with_low_mem (dwz.c:16227)
> ==2502==    by 0x13FEAE: dwz_one_file (dwz.c:16253)
> ==2502==    by 0x140B59: main (dwz.c:16532)
> ==2502==  Uninitialised value was created by a stack allocation
> ==2502==    at 0x13FE7F: dwz_one_file (dwz.c:16245)
> 
> And indeed we see:
> 
> static int
> dwz_one_file (const char *file, const char *outfile)
> {
>   struct file_result res;
> 
>   if (stats_p)
>     init_stats (file);
> 
>   res.die_count = 0;
> 
>   return dwz_with_low_mem (file, outfile, &res, NULL);
> }
> 
> Defines and passes down res, but only initializes the die_count field.
> 
> Then in dwz_with_low_mem we simply pass that res to dwz:
> 
>   ret = (low_mem_die_limit == 0
>          ? 2
>          : dwz (file, outfile, res));
> 
> And in dwz the first thing we do is:
> 
>   if (res->res == -1)
>     return 1;
> 
> But res->res was never given a value and so could be anything.
> 

Hi Mark,

thanks for helping out with this.

I've fixed this now, and verified that the buildbot is back to all-green.

After seeing your analysis, I realized I had tried -fsanitize=address
but not valgrind, and indeed using valgrind I managed to reproduce the
problem myself.

I've submitted a patch proposing a check-valgrind target in the
Makefile, to remind me to try this next time.

Thanks,
- Tom

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/46/builds/98

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-arm64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi,

On Wed, Oct 14, 2020 at 12:20:39AM +0200, Mark Wielaard wrote:
> So that is obviously my last commit. Sorry. All three buildbot workers
> fail on the same testcase pr25109.sh which is no-multifile-prop. That
> testcase has an empty debug_line and no decl/call_files. It still
> generates a .debug_line entry (and because no files have been seen, it
> produces a DWARF5 line table, which might be a bug in itself). I don't
> yet understand why this fails on ppc64, ppc64le and arm64 only and not
> on any other arch. Still investigating.

That was fun. It was a buffer overflow causing some on stack variables
to change values, but for some reason only on ppc64, ppc64 and
arm64. But it should have caused issues on all arches.

Pushed to attached fix.

Cheers,

Mark

[-- Attachment #2: 0001-Fix-buffer-overflow-in-write_multifile_line.patch --]
[-- Type: text/x-diff, Size: 1224 bytes --]

From babfff7baedefd5830340e2ad583b7732a895c49 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Wed, 14 Oct 2020 12:30:27 +0200
Subject: [PATCH] Fix buffer overflow in write_multifile_line.

When writing out a "header only" .debug_line we use a small static
buffer on the stack. Make sure this buffer is large enough to contain
a DWARF5 empty line table header.

ChangeLog:

	* dwz.c (write_multi_line): Extend buf to 45 chars. Add assert
	to check buf is large enough.
---
 dwz.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dwz.c b/dwz.c
index 1e6ec26..f8f2910 100644
--- a/dwz.c
+++ b/dwz.c
@@ -14304,7 +14304,7 @@ write_multifile_line (void)
   struct line_entry **filearr = NULL;
   struct line_stats line_stats;
   unsigned int *diridx = NULL, *dirarr = NULL;
-  unsigned char buf[17];
+  unsigned char buf[45]; /* Max header_len, see below.  */
   int ret = 0;
 
   line_stats.has_time = line_stats.has_size = false;
@@ -14430,7 +14430,10 @@ write_multifile_line (void)
 	}
 
       if (len == header_len)
-	line = buf;
+	{
+	  line = buf;
+	  assert (sizeof (buf) >= header_len);
+	}
       else
 	line = (unsigned char *) obstack_alloc (&ob, len);
     }
-- 
2.20.1

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

Hi,

On Tue, Oct 13, 2020 at 09:29:27PM +0000, buildbot@builder.wildebeest.org wrote:
> The Buildbot has detected a failed build on builder whole buildset while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/20/builds/236
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-ppc64le
> 
> BUILD FAILED: failed test (failure)
> 
> The Buildbot has detected a failed build on builder whole buildset while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/22/builds/237
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-ppc64
> 
> Build Reason: <unknown>
> Blamelist: Mark Wielaard <mark@klomp.org>
> 
> BUILD FAILED: failed test (failure)
> 
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/46/builds/12
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: debian-arm64

So that is obviously my last commit. Sorry. All three buildbot workers
fail on the same testcase pr25109.sh which is no-multifile-prop. That
testcase has an empty debug_line and no decl/call_files. It still
generates a .debug_line entry (and because no files have been seen, it
produces a DWARF5 line table, which might be a bug in itself). I don't
yet understand why this fails on ppc64, ppc64le and arm64 only and not
on any other arch. Still investigating.

Cheers,

Mark

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/20/builds/236

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64le

Build Reason: <unknown>
Blamelist: Mark Wielaard <mark@klomp.org>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/22/builds/237

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64

Build Reason: <unknown>
Blamelist: Mark Wielaard <mark@klomp.org>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/46/builds/12

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-arm64

Build Reason: <unknown>
Blamelist: Mark Wielaard <mark@klomp.org>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

On Sun, 2020-07-19 at 23:00 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/24/builds/223
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: debian-armhf
> 
> Build Reason: <unknown>
> Blamelist: Tom de Vries <tdevries@suse.de>
> 
> BUILD FAILED: failed test (failure)

My apologies, this is me testing a new arm32 debian builder.
I had forgotten to install dejagnu. It is installed now.
And a rebuild has been queued.

Cheers,

Mark

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/24/builds/223

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-armhf

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

Hi,

On Thu, 2020-01-16 at 14:18 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/20/builds/202

Just for the record. This was because of a sudden high load on
sourceware.org where the dwz.git repo is hosted. This caused the git
update on some builders to fail. The situation has been restored and
all builds are green again.

Cheers,

Mark

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/20/builds/202

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64le

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed update (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/22/builds/202

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed update (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/24/builds/200

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-armhf

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed update (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/25/builds/202

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed update (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/27/builds/200

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-i386

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed update (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/19/builds/34

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-x86_64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/20/builds/35

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64le

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/22/builds/35

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/25/builds/34

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

On Fri, 2019-03-29 at 21:42 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/19/builds/34
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-x86_64

Which is Fedora 29. The other builders that fail are also Fedora based.
The Debian and CentOS builds still seem to work.

The problem is this commit:

commit 388977c1ccdaf376540a651ee34cdf709891e0fe
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Mar 29 21:55:24 2019 +0100

    Compile dwz-for-tests with -U__GNUC__

Undefining __GNUC__ causes issues with some include files,
specifically:

In file included from /usr/include/bits/floatn.h:119,
                 from /usr/include/stdlib.h:55,
                 from dwz.c:30

__GNUC__ defines the major version of GCC (8 on Fedora 29).

Since GCC 7 the compiler defines the builtin types _Float32 and
_Float64 so floatn.h doesn't have to define them. But since we undefine
__GNUC__ the header cannot check the GCC version anymore and tries to
define them anyway. Causing the compile error.

I think the commit should just be reverted.
It isn't clear to me what it really tries to check for.

Cheers,

Mark

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Tom de Vries]

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

On 30-03-19 00:42, Mark Wielaard wrote:
> On Fri, 2019-03-29 at 21:42 +0000, buildbot@builder.wildebeest.org
> wrote:
>> The Buildbot has detected a failed build on builder whole buildset
>> while building dwz.
>> Full details are available at:
>>     https://builder.wildebeest.org/buildbot/#builders/19/builds/34
>>
>> Buildbot URL: https://builder.wildebeest.org/buildbot/
>>
>> Worker for this Build: fedora-x86_64
> 
> Which is Fedora 29. The other builders that fail are also Fedora based.
> The Debian and CentOS builds still seem to work.
> 
> The problem is this commit:
> 
> commit 388977c1ccdaf376540a651ee34cdf709891e0fe
> Author: Tom de Vries <tdevries@suse.de>
> Date:   Fri Mar 29 21:55:24 2019 +0100
> 
>     Compile dwz-for-tests with -U__GNUC__
> 
> Undefining __GNUC__ causes issues with some include files,
> specifically:
> 
> In file included from /usr/include/bits/floatn.h:119,
>                  from /usr/include/stdlib.h:55,
>                  from dwz.c:30
> 
> __GNUC__ defines the major version of GCC (8 on Fedora 29).
> 
> Since GCC 7 the compiler defines the builtin types _Float32 and
> _Float64 so floatn.h doesn't have to define them. But since we undefine
> __GNUC__ the header cannot check the GCC version anymore and tries to
> define them anyway. Causing the compile error.
> 

Thanks for the investigation.

> I think the commit should just be reverted.
> It isn't clear to me what it really tries to check for.

I'm trying to make sure that dwz builds in !__GNUC__ mode.

Fixed in attached commit, buildbot status back to all clear.

Thanks,
- Tom


[-- Attachment #2: 0001-Fix-dwz-for-test-build-failure-on-fedora.patch --]
[-- Type: text/x-patch, Size: 1699 bytes --]

Fix dwz-for-test build failure on fedora

Commit "Compile dwz-for-tests with -U__GNUC__" makes sure we we trigger the
!__GNUC__ path.  But -U__GNUC__ makes compilation of dwz-for-test failure on
fedora.

Instead, generate sources for dwz-for-test with __GNUC__ replaced by
NOT_DEFINED.

2019-03-30  Tom de Vries  <tdevries@suse.de>

	* Makefile (DWZ_TEST_SOURCES): New variable.
	(%-for-test.c): New target.  Generate %-for-test.c from %.c with
	__GNUC__ replaced by NOT_DEFINED.
	(dwz-for-test): Remove -U__GNUC__.  Use DWZ_TEST_SOURCES.
	(check): Remove DWZ_TEST_SOURCES when done.

---
 Makefile | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 0ce4482..7150d4a 100644
--- a/Makefile
+++ b/Makefile
@@ -29,9 +29,14 @@ dw2-restrict:
 py-section-script:
 	$(CC) $(TEST_SRC)/py-section-script.s -o $@ -g || touch $@
 
-dwz-for-test:
-	$(CC) $(patsubst %.o,%.c,$(OBJECTS)) -O2 -g -lelf -o $@ -Wall -W \
-	  -D_FILE_OFFSET_BITS=64 -DDWZ_VERSION='"for-test"' -U__GNUC__
+DWZ_TEST_SOURCES := $(patsubst %.o,%-for-test.c,$(OBJECTS))
+
+%-for-test.c: %.c
+	sed 's/__GNUC__/NOT_DEFINED/' $< > $@
+
+dwz-for-test: $(DWZ_TEST_SOURCES)
+	$(CC) $(DWZ_TEST_SOURCES) -O2 -g -lelf -o $@ -Wall -W \
+	  -D_FILE_OFFSET_BITS=64 -DDWZ_VERSION='"for-test"'
 
 # On some systems we need to set and export DEJAGNU to suppress
 # WARNING: Couldn't find the global config file.
@@ -43,4 +48,4 @@ check: dwz $(TEST_EXECS)
 	export DEJAGNU=$(DEJAGNU); \
 	export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
 	runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
-	rm -Rf testsuite-bin $(TEST_EXECS)
+	rm -Rf testsuite-bin $(TEST_EXECS) $(DWZ_TEST_SOURCES)

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/24/builds/52

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-armhf

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/27/builds/52

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-i386

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/25/builds/64

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/24/builds/60

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-armhf

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/27/builds/60

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-i386

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/21/builds/79

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: centos-x86_64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/26/builds/79

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: centos-aarch64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/25/builds/108

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed compile (failure)

Sincerely,
 -The Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard]

On Mon, 2019-10-21 at 10:10 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/25/builds/108
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-s390x
> 
> Build Reason: <unknown>
> Blamelist: Tom de Vries <tdevries@suse.de>
> 
> BUILD FAILED: failed compile (failure)

Sorry, the s390x buildbot ran out of disk space again.
It has been cleaned up and the build now succeeds:
https://builder.wildebeest.org/buildbot/#/builders/25/builds/109

But there is a suspicious snprintf warning.

Cheers,

Mark

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/19/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-x86_64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/20/builds/117

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64le

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/21/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: centos-x86_64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/22/builds/117

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-ppc64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/23/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-amd64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/24/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-armhf

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/25/builds/118

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: fedora-s390x

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/26/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: centos-aarch64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The BuildbotThe Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/27/builds/116

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: debian-i386

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot

Buildbot failure in Wildebeest Builder on whole buildset

[buildbot]

The Buildbot has detected a failed build on builder whole buildset while building dwz.
Full details are available at:
    https://builder.wildebeest.org/buildbot/#builders/21/builds/171

Buildbot URL: https://builder.wildebeest.org/buildbot/

Worker for this Build: centos-x86_64

Build Reason: <unknown>
Blamelist: Tom de Vries <tdevries@suse.de>

BUILD FAILED: failed test (failure)

Sincerely,
 -The Buildbot