From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 1FADB3858001 for ; Thu, 25 Mar 2021 20:34:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1FADB3858001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 220F03000AC8; Thu, 25 Mar 2021 21:34:10 +0100 (CET) Received: by librem (Postfix, from userid 1000) id A6802C3587; Thu, 25 Mar 2021 21:32:54 +0100 (CET) Date: Thu, 25 Mar 2021 21:32:54 +0100 From: Mark Wielaard To: Tom de Vries Cc: dwz@sourceware.org, jakub@redhat.com Subject: Re: [PATCH] Add check-valgrind Message-ID: <20210325203254.GG2685@wildebeest.org> References: <20210325135716.GA10490@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325135716.GA10490@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 20:34:13 -0000 Hi, On Thu, Mar 25, 2021 at 02:57:17PM +0100, Tom de Vries wrote: > Add a make target check-valgrind, that applies valgrind to dwz when used in > the testsuite. > > Any comments? It might be good to simply always run under valgrind when it is installed. That makes make check slightly slower by default, but it makes sure things are always also ran under valgrind if available. To make sure that a valgrind tool error really causes a check failure use --error-exitcode=99 (or some other non-zero code): --error-exitcode= [default: 0] Specifies an alternative exit code to return if Valgrind reported any errors in the run. When set to the default value (zero), the return value from Valgrind will always be the return value of the process being simulated. When set to a nonzero value, that value is returned instead, if Valgrind detects any errors. This is useful for using Valgrind as part of an automated test suite, since it makes it easy to detect test cases for which Valgrind has reported errors, just by inspecting return codes. Cheers, Mark