public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, jakub@redhat.com, Michael Matz <matz@suse.de>
Subject: Re: [PATCH] Add -p native and -e native
Date: Fri, 9 Apr 2021 11:42:31 +0200	[thread overview]
Message-ID: <20210409094231.GD30119@wildebeest.org> (raw)
In-Reply-To: <20210409092439.GA17210@delia>

On Fri, Apr 09, 2021 at 11:24:41AM +0200, Tom de Vries wrote:
> Add option parameter native to options -p and -e.
> 
> We determine native as the result of:
> - -p: sizeof (void *)
> - -e: __BYTE_ORDER__
> when compiling using CC without CFLAGS, such that if we build dwz with -m32 on
> x86_64 like so:
> ...
> $ make CFLAGS="-m32 -O2 -g" LDFLAGS=-m32
> ...
> and we have:
> ...
> $ file ./dwz
> dwz: ELF 32-bit LSB executable, Intel 80386 <SNIP>
> ...
> we still have:
> ...
> $ ./dwz -?
>   ...
>   -p, --multifile-pointer-size <SIZE|auto|native>
>                               Set pointer size of multifile, in number of bytes.
>                               Native pointer size is 8.
>                               Default value: auto.
> ...
> 
> Any comments?

Except for this narrow multilib case, doesn't this actually make it
impossible to do a cross-arch build? I don't think this should be a
compile time option, unless it can derived from the target
architecture that the dwz binary is build for.

Cheers,

Mark

  reply	other threads:[~2021-04-09  9:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  9:24 Tom de Vries
2021-04-09  9:42 ` Mark Wielaard [this message]
2021-04-09 12:48   ` Tom de Vries
2021-04-09 13:03   ` Michael Matz
2021-04-09 15:58     ` Tom de Vries
2021-04-12 12:33       ` Michael Matz
2021-04-12 15:11         ` Tom de Vries
2021-04-12 19:53           ` [committed] " Tom de Vries
2021-04-12 20:14       ` [PATCH] " Mark Wielaard
2021-04-13  7:45         ` Tom de Vries
2021-04-13  8:33           ` Tom de Vries
2021-04-13 10:04             ` Mark Wielaard
2021-04-13 11:15               ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409094231.GD30119@wildebeest.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=matz@suse.de \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).