On 11-12-2019 14:15, Michael Matz wrote:
> Hello,
> 
> On Tue, 10 Dec 2019, Tom de Vries wrote:
> 
>>> Seriously, this is nice.  The additional reduction of using the ODR rule 
>>> on cc1 isn't as big as I thought in the past, probably the largest stuff 
>>> in .debug_info aren't type descriptions anymore, but still, it's a 22% 
>>> reduction on top, so nothing to sneeze at.  (Maybe for firefox it's more, 
>>> I remember Honza moaning about many multiple struct type chains that 
>>> only differed in the completeness of their pointer members)
>>
>> I'd hope that the --odr-mode=unify in a future patch series will bring
>> further improvement, but we'll have to see how much.
>>
>> As for this patch series, I'm planning to commit in a couple of days,
>> unless there are serious objections.
>>
>> Could you at least review the user visible parts? Command line option 
>> names, man page entries (and usage ... oops, I forgot to update usage).
> 

That's done: https://sourceware.org/ml/dwz/2019-q4/msg00147.html .

> If you mean me: I'm fine with the names,

Ack.

> but would expand a little bit on 
> the explanations.  For --odr I would add a sentence describing the effect 
> of applying the ODR rule (without going into too much detail), i.e. 
> mention that this causes type DIEs that have to be the same per C++ rules 
> (same name basically) to be more forcefully deduped.  Also a 
> description of the two modes basic/link might be in order for the user to 
> make a meaningful choice; alteratively describe it as debug/development 
> option if the user isn't supposed to use it in regular use.
> 

I've updated the man page entries with your suggestions.

Better like this?

Thanks,
- Tom