From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76685 invoked by alias); 27 Nov 2019 13:44:48 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 76620 invoked by uid 89); 27 Nov 2019 13:44:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=lands, 27112019, HX-Languages-Length:2157 X-Spam-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Subject: Re: [Highlight] Performance improvements To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , dwz@sourceware.org, Jakub Jelinek , Mark Wielaard , Michael Matz References: From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <5000ad54-f6c7-a164-7519-82e84f91f6db@suse.de> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SW-Source: 2019-q4/txt/msg00085.txt.bz2 On 27-11-2019 13:52, Martin Liška wrote: > On 11/26/19 6:59 PM, Tom de Vries wrote: >> Hi, >> >> I've been working on performance improvements for dwz, using a cc1 >> binary as my optimization vehicle. >> >> Comparing the situation: >> - before (commit 04a676d Add --devel-partition-dups-opt), and >> - after (current master, commit e405c62 Add --devel-die-count-method >>    {none,estimate}) >> I get the following results. >> >> When avoiding running into the low-mem die-limit using -lnone, we get >> ~25% performance improvement, due to an improved hash function and an >> improved hash table allocation strategy (without increasing peak memory >> usage): >> ... >> real:  mean:  7378.10  100.00%  stddev:  45.31 >>         mean:  5558.80   75.34%  stddev:  35.18 >> user:  mean:  7106.30  100.00%  stddev:  41.53 >>         mean:  5328.10   74.98%  stddev:  22.33 >> sys:   mean:   271.60  100.00%  stddev:  39.57 >>         mean:   230.00   84.68%  stddev:  40.45 >> ... >> >> And if we don't avoid running into the low-mem die-limit, we get ~38% >> performance improvement: >> ... >> real:  mean:  15084.80 100.00%  stddev:  44.53 >>         mean:   9232.90  61.21%  stddev:  41.80 >> user:  mean:  14759.40 100.00%  stddev:  30.62 >>         mean:   9100.10  61.66%  stddev:  41.75 >> sys:   mean:    324.00 100.00%  stddev:  39.51 >>         mean:    132.00  40.74%  stddev:  27.26 >> ... >> which is also paired with a reduction in peak memory usage of ~34%, from >> 0.95GB to 0.63GB, due to running into the low-mem die-limit in a more >> efficient manner. > > Hi. > > That sounds very promising! I would like to see it being used in our > openSUSE > package. Are you planning to use it? > For the dwz openSUSE package I follow the usual strategy: backport bugfixes and upgrade to newer releases, once available. So, the intention is that this lands in openSUSE with the next release. I'm currently working on a dwz bug fix, and if that is done, and I manage to finalize the odr stuff as well, I think it'll be time for a new release. Thanks, - Tom