From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54457 invoked by alias); 12 Aug 2019 15:18:23 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 54443 invoked by uid 89); 12 Aug 2019 15:18:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=2003, tagging X-Spam-Status: No, score=-26.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Subject: Re: [PATCH] Add do-release.sh To: Jakub Jelinek Cc: dwz@sourceware.org, Michael Matz References: <20190722074131.GA32307@delia> <20190729172036.GF15878@tucnak> From: Tom de Vries Openpgp: preference=signencrypt Autocrypt: addr=tdevries@suse.de; keydata= mQENBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAG0H1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT6JAVQEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDuhV2rbOJEoHOPB/0Wtpauad3R7K5UC6jOzevBaHkQ39zzHr18jJawmAxi1Z3EMDMNzvwJ KLrJLVykONgzyYeuc6FwdtslLfJtINdsZC2sffChSeTclJaGuh35S5fsEC/7mYyHTVEGh0C8 NxysETFYuJdPyYf08oGBtQ7ZvCOKO9PCUuMvBkMaEFC9M9TjPYcjN4CNllU08qa7AR8thIzD rv9l6aHfeaRfH/dMwS2o8uqlxJ8ZXLKq3jGqppMyp9yk2aVkcTQEvyB9xWxkPt0aVpDRkiac HxDFQnsiuWtZ+8rdaaHXdWo2OZgNY3GlJhqaasfNu/E6srXjXtQf6W4lLdi/1oZ04FtTQtUA uQENBF0ltCcBCADPfR9+AbuDCjOxwyVbfOuDF28ewdTPd8FZaSe1KvlwxQ9ANISGpdNvI/oe owOm4c1raOEVHw5f/Zp9UrZ4DVRaL78LX822pqevlqSh2ZvV+WL5SMAsdd9ZE8QjQ3Bfv2nU VuJ/AlN6WVmJjVaoTFIjy8RJQOkIV07VQYdUZIwmUCpm3dbM73Dn2g/LPrSQASczWbJjtoVb hcJA60TfCYK4fdmvsh0D3ffkcm1tpe7Cb9up5FB+WebPOD+vPeHm4IpnKayXQJIyU4Ka5dZ4 YL6bVOTPVL/OT33q6IdoK6EBALUT5Qhq2dv9qlTXvVyX0mG4snnbwKVnCbOQzgck2ipHABEB AAGJATwEGAEIACYWIQSsnSe5hKbLMK1mGmjuhV2rbOJEoAUCXSW0JwIbDAUJA8JnAAAKCRDu hV2rbOJEoPe3B/sEBAFnxOpHzXbMoAPtuI6dYgnQxxXvY8UHGYsgenbhRV7RmiC1gzFJYouD dyyHTItXBzsfe+V3Mn0CgrdDGnRDor+sM55TLccyp7BAZyquxFGHQ1cMhCTkKBKtmyU97juo ht7c7uKT8wKrfUU0gBAk+YpdfbkHXXkwzORIqW/i51/Hsp3LEetNKTBZkCstCIRmPkobhwIq EigzKA9MDdTIZoi8j8EY60dntsQFVQIUMV85Ynbog4Kg+dJVS8o8Q4f12/6w3LuPIGw/lDF5 OrDEL/Vm01INQJIVCOoDpsQbAzbZ0/w5RjpIL3jHUbzUD3/Fu2b0tDEqbQSIMfwoEwt9 Message-ID: <573e6c65-9e69-5fe1-e156-f6ccd6b700b8@suse.de> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729172036.GF15878@tucnak> Content-Type: multipart/mixed; boundary="------------1B2EE7808921306B6BF62CC1" Content-Language: en-US X-SW-Source: 2019-q3/txt/msg00093.txt.bz2 This is a multi-part message in MIME format. --------------1B2EE7808921306B6BF62CC1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 1652 On 29-07-19 19:20, Jakub Jelinek wrote: > On Mon, Jul 22, 2019 at 09:41:33AM +0200, Tom de Vries wrote: >> Hi, >> >> this commit adds a script that: >> - bumps either the minor or the major version, using options >> --major or --minor >> - updates VERSION >> - commits VERSION update >> - tags VERSION update >> >> OK for trunk? >> >> Is there anything else involved in doing a release? > > I think that is all, bumping VERSION, commiting and tagging was all I did in > the past. > > One thing that might be worth doing is bump copyright years on files you've > modified, I know dwz.c has been using mostly Red Hat copyright, if you want > to use say FSF copyright, can you change that 2003 in there to 2003, 2019? > Or do you want to use SUSE copyright instead? > I guess because I have touched dwz.c last year the RH copyright should be > -2018 instead of -2015 too, and dwarf2.def should be probably changed to > 1992-2018 FSF copyright, using the simple range. After the release we > should likely import new dwarf2.def and dwarf2.h from GCC tree. Hmm, something I overlooked: ... $ ./dwz --version dwz version 0.13 Copyright (C) 2001-2012 Red Hat, Inc. Copyright (C) 2003 Free Software Foundation, Inc. ... We've updated the copyright in the file headers, but not in the version message. Patch below fixes this, updating the message using the copyright from the dwz.c file header. I wonder though, what about the copyright in the other files: dwarf2.def, dwarf2.h, dwarfnames.c, hashtab.c, hashtab.h, sha1.c and sha1.h? Should we take the copyright in those files into account as well? Or is it just dwz.c that matters? Thanks, - Tom --------------1B2EE7808921306B6BF62CC1 Content-Type: text/x-patch; name="0001-Update-version-copyright-message.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Update-version-copyright-message.patch" Content-length: 953 Update --version copyright message In commit 9a663b4 "Update copyright" we've updated copyright in the sources, but not in the --version copyright message. Update the --version copyright message. 2019-08-12 Tom de Vries * dwz.c (version): Update copyright message. --- dwz.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dwz.c b/dwz.c index 266f56d..6f58134 100644 --- a/dwz.c +++ b/dwz.c @@ -12395,8 +12395,9 @@ version (void) { fprintf (stderr, "dwz version " DWZ_VERSION "\n" - "Copyright (C) 2001-2012 Red Hat, Inc.\n" + "Copyright (C) 2001-2018 Red Hat, Inc.\n" "Copyright (C) 2003 Free Software Foundation, Inc.\n" + "Copyright (C) 2019 SUSE LLC." "This program is free software; you may redistribute it under the terms of\n" "the GNU General Public License version 3 or (at your option) any later version.\n" "This program has absolutely no warranty.\n"); --------------1B2EE7808921306B6BF62CC1--