public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@elastic.org>, dwz@sourceware.org
Subject: Re: dwz testsuite patch: version tagging
Date: Tue, 12 Jul 2022 15:37:25 +0200	[thread overview]
Message-ID: <5a9187b8e4a05af37a56c0f499de4149eee3d253.camel@klomp.org> (raw)
In-Reply-To: <YsW8FtOqNibFmsUj@elastic.org>

Hi Frank,

On Wed, 2022-07-06 at 12:45 -0400, Frank Ch. Eigler via Dwz wrote:
> The following little obvious patch adds the usual dejagnu trailer to
> the .log/.sum files.

So for me this adds:
/opt/local/src/dwz/testsuite-bin/dwz version 0.14
to the end of dwz.log and dwz.sum

Which is "correct" but also not that useful imho.

It is correct in that make check will create that directory copy a dwz
executable there, run the tests and delete that directory and test
binary again.

It is not that useful because the version string isn't really enough to
know what was being tested. It would be nice if it could include the
top of git hash for example.

Not against adding more info to the dwz.log/sum files though.

Cheers,

Mark

> 
> diff --git a/testsuite/config/default.exp
> b/testsuite/config/default.exp
> index e69de29bb2d1..16785528e489 100644
> --- a/testsuite/config/default.exp
> +++ b/testsuite/config/default.exp
> @@ -0,0 +1,8 @@
> +
> +
> +
> +proc dwz_version {} {
> +  set location [exec /usr/bin/which dwz]
> +  regexp {version [0-9.]*} [exec dwz --version 2>@ stdout] version
> +  clone_output "$location $version"
> +}

  reply	other threads:[~2022-07-12 13:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 16:45 Frank Ch. Eigler
2022-07-12 13:37 ` Mark Wielaard [this message]
2022-07-12 13:39   ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a9187b8e4a05af37a56c0f499de4149eee3d253.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=fche@elastic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).