From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 407223856968 for ; Tue, 12 Jul 2022 13:37:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 407223856968 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 001E0302AB2C; Tue, 12 Jul 2022 15:37:26 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id D755F400B8BD; Tue, 12 Jul 2022 15:37:25 +0200 (CEST) Message-ID: <5a9187b8e4a05af37a56c0f499de4149eee3d253.camel@klomp.org> Subject: Re: dwz testsuite patch: version tagging From: Mark Wielaard To: "Frank Ch. Eigler" , dwz@sourceware.org Date: Tue, 12 Jul 2022 15:37:25 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 13:37:29 -0000 Hi Frank, On Wed, 2022-07-06 at 12:45 -0400, Frank Ch. Eigler via Dwz wrote: > The following little obvious patch adds the usual dejagnu trailer to > the .log/.sum files. So for me this adds: /opt/local/src/dwz/testsuite-bin/dwz version 0.14 to the end of dwz.log and dwz.sum Which is "correct" but also not that useful imho. It is correct in that make check will create that directory copy a dwz executable there, run the tests and delete that directory and test binary again. It is not that useful because the version string isn't really enough to know what was being tested. It would be nice if it could include the top of git hash for example. Not against adding more info to the dwz.log/sum files though. Cheers, Mark >=20 > diff --git a/testsuite/config/default.exp > b/testsuite/config/default.exp > index e69de29bb2d1..16785528e489 100644 > --- a/testsuite/config/default.exp > +++ b/testsuite/config/default.exp > @@ -0,0 +1,8 @@ > + > + > + > +proc dwz_version {} { > + set location [exec /usr/bin/which dwz] > + regexp {version [0-9.]*} [exec dwz --version 2>@ stdout] version > + clone_output "$location $version" > +}