From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id DA507386EC5D
 for <dwz@sourceware.org>; Fri,  2 Oct 2020 17:43:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA507386EC5D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 3AFAD300D923;
 Fri,  2 Oct 2020 19:43:16 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id DB7594000C71; Fri,  2 Oct 2020 19:43:16 +0200 (CEST)
Message-ID: <62b131c1acd1397799117165611020c8d326c8ea.camel@klomp.org>
Subject: Re: [committed] Fix error: Unknown DWARF DW_FORM_ref_sig8
From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>, Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, Mark Wielaard <mark@gcc.gnu.org>
Date: Fri, 02 Oct 2020 19:43:16 +0200
In-Reply-To: <20201002171037.GY2176@tucnak>
References: <20201002170521.GA31168@delia> <20201002171037.GY2176@tucnak>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Oct 2020 17:43:20 -0000

On Fri, 2020-10-02 at 19:10 +0200, Jakub Jelinek wrote:
> On Fri, Oct 02, 2020 at 07:05:22PM +0200, Tom de Vries wrote:
> > Fix by using this instead:
> > ...
> >                  && !(form =3D=3D DW_FORM_ref_sig8
> >                       || form =3D=3D DW_FORM_data16
> >                       || form =3D=3D DW_FORM_line_strp)))
> > ...
>=20
> Sorry for not catching it in the review.

Actually you did, you did say the logic was wrong, but then we
remembered that for DWARF4 we had:

[...]
DW_FORM_flag_present =3D 0x19
DW_FORM_ref_sig8     =3D 0x20

(haha, someone forgot how to count in hex, should have been 0x1a)

which made the original logic correct. But not what I ended up
writing... doh.

Thanks for catching that Tom.
I have no idea how this got through my testing :{

Cheers,

Mark