On 30-03-19 00:42, Mark Wielaard wrote:
> On Fri, 2019-03-29 at 21:42 +0000, buildbot@builder.wildebeest.org
> wrote:
>> The Buildbot has detected a failed build on builder whole buildset
>> while building dwz.
>> Full details are available at:
>>     https://builder.wildebeest.org/buildbot/#builders/19/builds/34
>>
>> Buildbot URL: https://builder.wildebeest.org/buildbot/
>>
>> Worker for this Build: fedora-x86_64
> 
> Which is Fedora 29. The other builders that fail are also Fedora based.
> The Debian and CentOS builds still seem to work.
> 
> The problem is this commit:
> 
> commit 388977c1ccdaf376540a651ee34cdf709891e0fe
> Author: Tom de Vries <tdevries@suse.de>
> Date:   Fri Mar 29 21:55:24 2019 +0100
> 
>     Compile dwz-for-tests with -U__GNUC__
> 
> Undefining __GNUC__ causes issues with some include files,
> specifically:
> 
> In file included from /usr/include/bits/floatn.h:119,
>                  from /usr/include/stdlib.h:55,
>                  from dwz.c:30
> 
> __GNUC__ defines the major version of GCC (8 on Fedora 29).
> 
> Since GCC 7 the compiler defines the builtin types _Float32 and
> _Float64 so floatn.h doesn't have to define them. But since we undefine
> __GNUC__ the header cannot check the GCC version anymore and tries to
> define them anyway. Causing the compile error.
> 

Thanks for the investigation.

> I think the commit should just be reverted.
> It isn't clear to me what it really tries to check for.

I'm trying to make sure that dwz builds in !__GNUC__ mode.

Fixed in attached commit, buildbot status back to all clear.

Thanks,
- Tom