From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45966 invoked by alias); 30 Mar 2019 07:42:44 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 45952 invoked by uid 89); 30 Mar 2019 07:42:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,URIBL_BLOCKED autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,URIBL_BLOCKED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset To: Mark Wielaard , dwz@sourceware.org References: <20190329214227.59AA4817A87@builder.wildebeest.org> <8f249c07c1cb9a6cbf78eec5c05b3c5641cd5526.camel@klomp.org> From: Tom de Vries Message-ID: <6db21006-1eed-1224-bc42-a665a757dc05@suse.de> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <8f249c07c1cb9a6cbf78eec5c05b3c5641cd5526.camel@klomp.org> Content-Type: multipart/mixed; boundary="------------263C4D7CBAA539D6D31D02B7" Content-Language: en-US X-SW-Source: 2019-q1/txt/msg00165.txt.bz2 This is a multi-part message in MIME format. --------------263C4D7CBAA539D6D31D02B7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 1591 On 30-03-19 00:42, Mark Wielaard wrote: > On Fri, 2019-03-29 at 21:42 +0000, buildbot@builder.wildebeest.org > wrote: >> The Buildbot has detected a failed build on builder whole buildset >> while building dwz. >> Full details are available at: >> https://builder.wildebeest.org/buildbot/#builders/19/builds/34 >> >> Buildbot URL: https://builder.wildebeest.org/buildbot/ >> >> Worker for this Build: fedora-x86_64 > > Which is Fedora 29. The other builders that fail are also Fedora based. > The Debian and CentOS builds still seem to work. > > The problem is this commit: > > commit 388977c1ccdaf376540a651ee34cdf709891e0fe > Author: Tom de Vries > Date: Fri Mar 29 21:55:24 2019 +0100 > > Compile dwz-for-tests with -U__GNUC__ > > Undefining __GNUC__ causes issues with some include files, > specifically: > > In file included from /usr/include/bits/floatn.h:119, > from /usr/include/stdlib.h:55, > from dwz.c:30 > > __GNUC__ defines the major version of GCC (8 on Fedora 29). > > Since GCC 7 the compiler defines the builtin types _Float32 and > _Float64 so floatn.h doesn't have to define them. But since we undefine > __GNUC__ the header cannot check the GCC version anymore and tries to > define them anyway. Causing the compile error. > Thanks for the investigation. > I think the commit should just be reverted. > It isn't clear to me what it really tries to check for. I'm trying to make sure that dwz builds in !__GNUC__ mode. Fixed in attached commit, buildbot status back to all clear. Thanks, - Tom --------------263C4D7CBAA539D6D31D02B7 Content-Type: text/x-patch; name="0001-Fix-dwz-for-test-build-failure-on-fedora.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Fix-dwz-for-test-build-failure-on-fedora.patch" Content-length: 1699 Fix dwz-for-test build failure on fedora Commit "Compile dwz-for-tests with -U__GNUC__" makes sure we we trigger the !__GNUC__ path. But -U__GNUC__ makes compilation of dwz-for-test failure on fedora. Instead, generate sources for dwz-for-test with __GNUC__ replaced by NOT_DEFINED. 2019-03-30 Tom de Vries * Makefile (DWZ_TEST_SOURCES): New variable. (%-for-test.c): New target. Generate %-for-test.c from %.c with __GNUC__ replaced by NOT_DEFINED. (dwz-for-test): Remove -U__GNUC__. Use DWZ_TEST_SOURCES. (check): Remove DWZ_TEST_SOURCES when done. --- Makefile | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 0ce4482..7150d4a 100644 --- a/Makefile +++ b/Makefile @@ -29,9 +29,14 @@ dw2-restrict: py-section-script: $(CC) $(TEST_SRC)/py-section-script.s -o $@ -g || touch $@ -dwz-for-test: - $(CC) $(patsubst %.o,%.c,$(OBJECTS)) -O2 -g -lelf -o $@ -Wall -W \ - -D_FILE_OFFSET_BITS=64 -DDWZ_VERSION='"for-test"' -U__GNUC__ +DWZ_TEST_SOURCES := $(patsubst %.o,%-for-test.c,$(OBJECTS)) + +%-for-test.c: %.c + sed 's/__GNUC__/NOT_DEFINED/' $< > $@ + +dwz-for-test: $(DWZ_TEST_SOURCES) + $(CC) $(DWZ_TEST_SOURCES) -O2 -g -lelf -o $@ -Wall -W \ + -D_FILE_OFFSET_BITS=64 -DDWZ_VERSION='"for-test"' # On some systems we need to set and export DEJAGNU to suppress # WARNING: Couldn't find the global config file. @@ -43,4 +48,4 @@ check: dwz $(TEST_EXECS) export DEJAGNU=$(DEJAGNU); \ export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \ runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS) - rm -Rf testsuite-bin $(TEST_EXECS) + rm -Rf testsuite-bin $(TEST_EXECS) $(DWZ_TEST_SOURCES) --------------263C4D7CBAA539D6D31D02B7--