From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 6407438708AA
 for <dwz@sourceware.org>; Tue, 29 Sep 2020 18:19:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6407438708AA
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 68EF930007DA;
 Tue, 29 Sep 2020 20:19:31 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 036CE470869E; Tue, 29 Sep 2020 20:19:30 +0200 (CEST)
Message-ID: <7af37960d85173dc28c4a29cff3f8eb94dc090e2.camel@klomp.org>
Subject: Re: [PATCH] Add write_sleb129 and size_of_sleb128 for writing
 DW_FORM_implicit_const
From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Date: Tue, 29 Sep 2020 20:19:30 +0200
In-Reply-To: <20200929082415.GW2176@tucnak>
References: <20200928073647.4629-1-mark@klomp.org>
 <20200929082415.GW2176@tucnak>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2020 18:19:33 -0000

Hi Jakub,

On Tue, 2020-09-29 at 10:24 +0200, Jakub Jelinek via Dwz wrote:
>=20
> The parens above are unnecessary.
> [...]
> And this has even more unnecessary parens.
> [...]
> Otherwise LGTM.

Thanks simplified those and fixed the commit message.
Haven't pushed this because the DW_FORM_implicit_const support isn't
100% yet. The is the memory issue and I think the hashing/checksum
isn't 100% correct because in DWARF5 mode I still see some odr
failures. I'll get back to that after finishing the DWARF5 .debug_line
support. For now the patches can be found here:
https://code.wildebeest.org/git/user/mjw/dwz/log/?h=3Ddwarf5-forms

Cheers,

Mark