From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83289 invoked by alias); 15 Mar 2019 15:14:30 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 83273 invoked by uid 89); 15 Mar 2019 15:14:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Specifically, HX-Languages-Length:552 X-Spam-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Subject: Re: [PATCH] Handle unsorted section header table From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com References: <20190312170735.GA21660@delia> Message-ID: <7dd48bbc-bfb4-ba7c-00c0-260f88a9c1d2@suse.de> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190312170735.GA21660@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SW-Source: 2019-q1/txt/msg00128.txt.bz2 On 12-03-19 18:07, Tom de Vries wrote: > Hi, > Handle unsorted section header table in write_dso by: > - rewriting loop (*) in sh_offset updating code to handle unsorted section > header table > (*) Specifically, this one: > ... > for (j = dso->ehdr.e_shstrndx + 1; j < dso->ehdr.e_shnum; ++j) > dso->shdr[j].sh_offset += len; > ... > I realized that this in itself is a potential wrong-code issue, submitted patch for it here ( https://sourceware.org/ml/dwz/2019-q1/msg00127.html ). Thanks, - Tom