public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: dwz@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <8f249c07c1cb9a6cbf78eec5c05b3c5641cd5526.camel@klomp.org> (raw)
In-Reply-To: <20190329214227.59AA4817A87@builder.wildebeest.org>

On Fri, 2019-03-29 at 21:42 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building dwz.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/19/builds/34
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-x86_64

Which is Fedora 29. The other builders that fail are also Fedora based.
The Debian and CentOS builds still seem to work.

The problem is this commit:

commit 388977c1ccdaf376540a651ee34cdf709891e0fe
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Mar 29 21:55:24 2019 +0100

    Compile dwz-for-tests with -U__GNUC__

Undefining __GNUC__ causes issues with some include files,
specifically:

In file included from /usr/include/bits/floatn.h:119,
                 from /usr/include/stdlib.h:55,
                 from dwz.c:30

__GNUC__ defines the major version of GCC (8 on Fedora 29).

Since GCC 7 the compiler defines the builtin types _Float32 and
_Float64 so floatn.h doesn't have to define them. But since we undefine
__GNUC__ the header cannot check the GCC version anymore and tries to
define them anyway. Causing the compile error.

I think the commit should just be reverted.
It isn't clear to me what it really tries to check for.

Cheers,

Mark

  reply	other threads:[~2019-03-29 23:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard [this message]
2019-01-01  0:00   ` Tom de Vries
  -- strict thread matches above, loose matches on Subject: below --
2021-03-26 13:04 buildbot
2021-03-25  8:41 buildbot
2020-10-13 21:29 buildbot
2020-10-13 22:20 ` Mark Wielaard
2020-10-14 10:36   ` Mark Wielaard
2020-07-19 23:00 buildbot
2020-07-19 23:17 ` Mark Wielaard
2020-01-01  0:00 buildbot
2020-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f249c07c1cb9a6cbf78eec5c05b3c5641cd5526.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).