From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id E6D6E384385C for ; Thu, 30 Jun 2022 14:23:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6D6E384385C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E5D891FDD6; Thu, 30 Jun 2022 14:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1656598982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgXNIT5E7AA4IsPhWImKzA3zWbY7xjM8JS+DzJKNHPE=; b=dQdMdIrecHHl8PF9kCYQRSLPWs/tgu+vNILVZkMcM07Jy78fp1JEgRl8qfM6iq7YMySm6Y 68612ClfNt1s7Im5Mf63XrgRUNx7cmcDrAxJBJu+ORg39fvBuquq0pQfkwyAQTp4Zu7f9J mVdANxlw8uZM2Ar9e46I009VSHgTT2E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1656598982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgXNIT5E7AA4IsPhWImKzA3zWbY7xjM8JS+DzJKNHPE=; b=ncQWDqHRJ15TVDmesRSaJXOO6xLUQ6FvTXpDlnCYgDGIV26KfA05uRdpy85JJ8tsO5Jzx/ 0NuvN+Zb8s9K71BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE2B713A5C; Thu, 30 Jun 2022 14:23:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nrXVLMaxvWL+ZwAAMHmgww (envelope-from ); Thu, 30 Jun 2022 14:23:02 +0000 Content-Type: multipart/mixed; boundary="------------TqQYMuIRvR03GwpfqSR0ZYjs" Message-ID: <9b8016f2-b9f4-b310-4a73-692f70e32799@suse.cz> Date: Thu, 30 Jun 2022 16:23:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: =?UTF-8?Q?Re=3a_=e2=98=ba_Buildbot_=28GNU_Toolchain=29=3a_dwz_-_bui?= =?UTF-8?Q?ld_successful_=28master=29?= Content-Language: en-US To: Mark Wielaard Cc: dwz@sourceware.org, Tom de Vries References: <20220625215613.349A43851AA8@sourceware.org> <8f2e7627-8084-1148-363f-6ac3b71b87f4@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 14:23:06 -0000 This is a multi-part message in MIME format. --------------TqQYMuIRvR03GwpfqSR0ZYjs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/28/22 23:43, Mark Wielaard wrote: > Hi, > > On Mon, Jun 27, 2022 at 09:25:23AM +0200, Martin Liška wrote: >> On 6/26/22 00:17, Mark Wielaard wrote: >>> The build is now green on all builders except one: >>> https://builder.sourceware.org/buildbot/#/builders?tags=dwz >>> dwz-opensusetw-x86_64 fails one testcase: odr-struct-ns.sh >>> https://builder.sourceware.org/buildbot/#/builders/100/builds/2 >>> >>> Martin, could you take a look at what is different on tumbleweed from >>> the other builders that makes that testcase fail? >> >> It's going to be likely GCC compiler version that plays role. >> >> Anyway, it's caused by: >> >> expected_decl_cnt: 20, decl_cnt: 10 > > I took a quick look and this seems to be caused by lots of extra > DW_AT_declaration in the original binary: > > readelf -wi odr-struct-ns | grep -3 DW_AT_declaration | grep name > <1c0> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at > <1d4> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 > <1e8> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl > <1fc> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon > <2c4> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp > <2d8> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx > <2ec> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso > <300> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns > <314> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un > <328> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 > <671> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at > <685> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 > <699> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl > <6ad> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon > <770> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp > <784> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx > <798> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso > <7ac> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns > <7c0> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un > <7d4> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 > <9e0> DW_AT_name : bbb > DW_AT_name : ccc Just to summarize it what we have for Tumbleweed and Leap: TW: ==before== <1c0> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at <1d4> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 <1e8> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl <1fc> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon <2c4> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp <2d8> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx <2ec> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso <300> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns <314> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un <328> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 <671> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at <685> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 <699> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl <6ad> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon <770> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp <784> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx <798> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso <7ac> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns <7c0> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un <7d4> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 <9e0> DW_AT_name : bbb DW_AT_name : ccc ==after== DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 <10a> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl <118> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon <1b6> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp <1c4> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx <1d2> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso <1e0> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns <1ee> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un <1fc> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 while Leap has: ==before== <105> DW_AT_name : bbb <1cb> DW_AT_name : ccc <2b3> DW_AT_name : (indirect string, offset: 0x4b6): __preinit_array_end <2be> DW_AT_name : (indirect string, offset: 0x2a5): __init_array_start <2c9> DW_AT_name : (indirect string, offset: 0x4ca): __init_array_end <2f1> DW_AT_name : (indirect string, offset: 0x2fd): __fini_array_end <2fc> DW_AT_name : (indirect string, offset: 0x2ed): __libc_csu_fini <3bb> DW_AT_linkage_name: (indirect string, offset: 0x33d): _init <3bf> DW_AT_name : (indirect string, offset: 0x33d): _init ==after== <27e> DW_AT_name : (indirect string, offset: 0x4b6): __preinit_array_end <286> DW_AT_name : (indirect string, offset: 0x2a5): __init_array_start <28e> DW_AT_name : (indirect string, offset: 0x4ca): __init_array_end <2ab> DW_AT_name : (indirect string, offset: 0x2fd): __fini_array_end <2b4> DW_AT_name : (indirect string, offset: 0x2ed): __libc_csu_fini <34c> DW_AT_linkage_name: (indirect string, offset: 0x33d): _init <350> DW_AT_name : (indirect string, offset: 0x33d): _init So as Florian said, we should ignore sockeraddr decls and check that bbb and ccc are not present after dwz. What about using the following patch? Martin > > Those sockaddr declarations come from this compilation unit: > > Compilation Unit @ offset 0x28: > Length: 0x4d2 (32-bit) > Version: 5 > Unit Type: DW_UT_compile (1) > Abbrev Offset: 0x14 > Pointer Size: 8 > <0><34>: Abbrev Number: 14 (DW_TAG_compile_unit) > <35> DW_AT_producer : (indirect string, offset: 0x1e5): GNU C11 12.1.0 -mtune=generic -march=x8 > 6-64 -g -O2 -std=gnu11 -fgnu89-inline -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protect > ion -fpatchable-function-entry=16,14 -fmerge-all-constants -frounding-math -fstack-protector-strong -fno > -common -fmath-errno -fpie -fcf-protection=full -ftls-model=initial-exec > <39> DW_AT_language : 29 (C11) > <3a> DW_AT_name : (indirect line string, offset: 0x45): ../sysdeps/x86/abi-note.c > <3e> DW_AT_comp_dir : (indirect line string, offset: 0x0): /home/abuild/rpmbuild/BUILD/glibc-2. > 35/csu > <42> DW_AT_stmt_list : 0x5d > > I am not sure why the abi-note would pull in all these sockeraddr declarations. > > Cheers, > > Mark > --------------TqQYMuIRvR03GwpfqSR0ZYjs Content-Type: text/x-patch; charset=UTF-8; name="0001-testsuite-verify-directly-merged-DW_AT_declarations.patch" Content-Disposition: attachment; filename*0="0001-testsuite-verify-directly-merged-DW_AT_declarations.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSBjMDBmZTU4ZDg0Mzc3NDgwNDE3OTMyNzlhYmNhZGJjZDM2NjBmYTVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUaHUsIDMwIEp1biAyMDIyIDE2OjIxOjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g dGVzdHN1aXRlOiB2ZXJpZnkgZGlyZWN0bHkgbWVyZ2VkIERXX0FUX2RlY2xhcmF0aW9ucwoK RG8gbm90IHJlbHkgb24gbnVtYmVyIG9mIERXX0FUX2RlY2xhcmF0aW9uIGFuZCBjaGVjayBz eW1ib2xzCmluc3RlYWQuCi0tLQogdGVzdHN1aXRlL2R3ei50ZXN0cy9vZHItc3RydWN0LW5z LnNoIHwgMTEgKysrKystLS0tLS0KIHRlc3RzdWl0ZS9kd3oudGVzdHMvb2RyLXN0cnVjdC5z aCAgICB8IDExICsrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMo KyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rlc3RzdWl0ZS9kd3oudGVzdHMv b2RyLXN0cnVjdC1ucy5zaCBiL3Rlc3RzdWl0ZS9kd3oudGVzdHMvb2RyLXN0cnVjdC1ucy5z aAppbmRleCA0ZmQwMGFmLi43YWNlNTM0IDEwMDY0NAotLS0gYS90ZXN0c3VpdGUvZHd6LnRl c3RzL29kci1zdHJ1Y3QtbnMuc2gKKysrIGIvdGVzdHN1aXRlL2R3ei50ZXN0cy9vZHItc3Ry dWN0LW5zLnNoCkBAIC0yMSw4ICsyMSw2IEBAIGZvciBuYW1lIGluIG1lbWJlcl9vbmUgbWVt YmVyX3R3byBtZW1iZXJfdGhyZWUgbWVtYmVyX2ZvdXI7IGRvCiAJZXNhYwogZG9uZQogCi1k ZWNsX2NudD0kKHJlYWRlbGYgLXdpIDEgfCBncmVwIC1jICJEV19BVF9kZWNsYXJhdGlvbiIg fHwgdHJ1ZSkKLQogJGV4ZWNzL2R3ei1mb3ItdGVzdCAtLW9kciAxCiAKIHZlcmlmeS1kd2Fy Zi5zaCAxCkBAIC0zOCw4ICszNiw5IEBAIGZvciBuYW1lIGluIG1lbWJlcl9vbmUgbWVtYmVy X3R3byBtZW1iZXJfdGhyZWUgbWVtYmVyX2ZvdXI7IGRvCiBkb25lCiAKICMgV2UgZXhwZWN0 IHR3byBkZWNscyB0byBiZSByZW1vdmVkLCBmb3IgYmJiIGFuZCBjY2MuCi1leHBlY3RlZF9k ZWNsX2NudD0kKCgkZGVjbF9jbnQgLSAyKSkKLWRlY2xfY250PSQocmVhZGVsZiAtd2kgMSB8 IGdyZXAgLWMgIkRXX0FUX2RlY2xhcmF0aW9uIiB8fCB0cnVlKQotWyAkZXhwZWN0ZWRfZGVj bF9jbnQgLWVxICRkZWNsX2NudCBdCityZWFkZWxmIC13aSAxIHwgZ3JlcCAtMyBEV19BVF9k ZWNsYXJhdGlvbiA+IGRlY2xzCisKK2lmIGdyZXAgYmJiIGRlY2xzID4vZGV2L251bGwgOyB0 aGVuIGV4aXQgMTsgZmkKK2lmIGdyZXAgY2NjIGRlY2xzID4vZGV2L251bGwgOyB0aGVuIGV4 aXQgMjsgZmkKIAotcm0gLWYgMQorcm0gLWYgMSBkZWNscwpkaWZmIC0tZ2l0IGEvdGVzdHN1 aXRlL2R3ei50ZXN0cy9vZHItc3RydWN0LnNoIGIvdGVzdHN1aXRlL2R3ei50ZXN0cy9vZHIt c3RydWN0LnNoCmluZGV4IGQwZmRkZjkuLjcwNjBjNjMgMTAwNjQ0Ci0tLSBhL3Rlc3RzdWl0 ZS9kd3oudGVzdHMvb2RyLXN0cnVjdC5zaAorKysgYi90ZXN0c3VpdGUvZHd6LnRlc3RzL29k ci1zdHJ1Y3Quc2gKQEAgLTIxLDggKzIxLDYgQEAgZm9yIG5hbWUgaW4gbWVtYmVyX29uZSBt ZW1iZXJfdHdvIG1lbWJlcl90aHJlZSBtZW1iZXJfZm91cjsgZG8KIAllc2FjCiBkb25lCiAK LWRlY2xfY250PSQocmVhZGVsZiAtd2kgMSB8IGdyZXAgLWMgIkRXX0FUX2RlY2xhcmF0aW9u IiB8fCB0cnVlKQotCiAkZXhlY3MvZHd6LWZvci10ZXN0IC0tb2RyIDEKIAogdmVyaWZ5LWR3 YXJmLnNoIDEKQEAgLTM4LDggKzM2LDkgQEAgZm9yIG5hbWUgaW4gbWVtYmVyX29uZSBtZW1i ZXJfdHdvIG1lbWJlcl90aHJlZSBtZW1iZXJfZm91cjsgZG8KIGRvbmUKIAogIyBXZSBleHBl Y3QgdHdvIGRlY2xzIHRvIGJlIHJlbW92ZWQsIGZvciBiYmIgYW5kIGNjYy4KLWV4cGVjdGVk X2RlY2xfY250PSQoKCRkZWNsX2NudCAtIDIpKQotZGVjbF9jbnQ9JChyZWFkZWxmIC13aSAx IHwgZ3JlcCAtYyAiRFdfQVRfZGVjbGFyYXRpb24iIHx8IHRydWUpCi1bICRleHBlY3RlZF9k ZWNsX2NudCAtZXEgJGRlY2xfY250IF0KK3JlYWRlbGYgLXdpIDEgfCBncmVwIC0zIERXX0FU X2RlY2xhcmF0aW9uID4gZGVjbHMKKworaWYgZ3JlcCBiYmIgZGVjbHMgPi9kZXYvbnVsbCA7 IHRoZW4gZXhpdCAxOyBmaQoraWYgZ3JlcCBjY2MgZGVjbHMgPi9kZXYvbnVsbCA7IHRoZW4g ZXhpdCAyOyBmaQogCi1ybSAtZiAxCitybSAtZiAxIGRlY2xzCi0tIAoyLjM2LjEKCg== --------------TqQYMuIRvR03GwpfqSR0ZYjs--