From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062.outbound.protection.outlook.com [40.107.223.62]) by sourceware.org (Postfix) with ESMTPS id CD757386FC1D for ; Mon, 24 May 2021 12:18:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD757386FC1D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AxuxJ3POlnpieTHWDWoqV+h0p0audRClUPqfo1AkojpvnkP5tEXo1+Ej4Ppwv88RwCDqA/OyKqngbqxoEpOIqaUvcYwJq7e/aU+oIYAfmIjxS6MRrDpw6Kzr3gFlr5CS4MRw+lWR87siVL/rH/qw8a2OkSQKsmqVfr4Ir9XaeZbxy+D+hs4/cTVpQ6ZAZgGQkCO8TrDabMikhflFxpZvQ/DUOQWpejW2yZ9RhVmcFxbuRILHLCAl4BT3utHog2EAUsu9ToR8K7pH0AKnVQNYIHKo4qY7FyVGwgUNCUpya3gq0EXp8/B8P+aYq/iKErcNOMDLZHmLeFjxZ9/1E1xqKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pMHgrtQxTHzajyLhbF3aiTkmbTPm3clPVwjVXbxT9Y=; b=oHAOKrQ6jgzZ8CFaNPDko6pR/3jVjnBfp5coIbPmsWlMv8p5+7dJZdhZLrx3B6RL57o2goLuBe2zInVRsh0QSr+Hx4c8WdMp+FtDNSRFZQFE0H1lEZte6Aq/YYCPqf9cDI7cpeH4mtA2ZvVQC60Pza/AB0ua0nXRyau5bz+o/84JWJ3P2mWTGIodRgn9ZlxGK1CSg2qFikOcrpoyT/33WDMkQGu6PV45uXt9b8yRrkcWSCE7upBoLFivzRA3k6yuPOylmoj243ifES5L45QQ75etvkifkPG3m5B0Dh9r2rUjdZTXaxosZwcSshWXnr9ahaeyNyI8T/eex6+Krz7lgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CH0PR12MB5265.namprd12.prod.outlook.com (2603:10b6:610:d0::22) by CH0PR12MB5076.namprd12.prod.outlook.com (2603:10b6:610:e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Mon, 24 May 2021 12:18:17 +0000 Received: from CH0PR12MB5265.namprd12.prod.outlook.com ([fe80::41b7:a794:d2f1:6a8e]) by CH0PR12MB5265.namprd12.prod.outlook.com ([fe80::41b7:a794:d2f1:6a8e%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 12:18:17 +0000 From: "E, Nagajyothi" To: Mark Wielaard , "dwz@sourceware.org" CC: "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "Parasuraman, Hariharan" , "E, Nagajyothi" Subject: RE: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang Thread-Topic: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang Thread-Index: AddKRyXCqliHcsK8S9KZNTaETuELegGT3Z/w Date: Mon, 24 May 2021 12:18:17 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2021-05-24T12:18:01Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=761579c5-dd92-43e5-b76d-09afaa26ddc3; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_justification: I confirm the recipients are approved for sharing this content x-originating-ip: [165.204.159.242] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 271473f8-adb6-4dda-13b1-08d91eae031f x-ms-traffictypediagnostic: CH0PR12MB5076: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sBWAne4Lq1gt3r4fRdUpdIBdImVdW4u8w0LWKGqm47koEWeLgFxfj4JWpvPmrcBiyyk3dO72ODYrqkuRYKdGeAI07o9tQYbI5J1Lheu/qCSdfRdVwO+33hciYWu5Vdoew/+JaQNQYkX5UMDN/T02JcvAjZBF+ruRFqhwapdr0qy2eNIotA41KqCI+zCc46Bp5bxFBaIiSw4pYunFTOiJip3H6Lb3+eGgW47Tm8DjKD7m9Dd7s6r5d8Cbbi0bZVKde+wbmsSB3rvdDkBbZNBVnEODYuH1sihXbslc4NaQQfGERsjMvtpjjni7saD88uIUzVvF5TC9qtyjzLppYzBunNFWvbxY7XVt0nAR4oBC1Sib1JcXWNIlJrZUYHoYm2BaG0MDOZu97fIbY5kphJ1ZKEocWN/GMWC+t0Tp9TIo0oYtB65v5H2lqnzTZsRTizfJ2tWFTIZpmU3/1QbY8BI7JmSDscrDGYvOE+hrRo5eRl6KwzMw0kzvy94EFuatvJNrS2ZS3/PAdUUmu1XDgcJBE8yIu8ru2ubyWQ/eS8nqXiUQ2BlQItl88oxPXQEqtQBdrqtqgIlswa1denxjTymemktbS85IClIvANsPvXC7qiCAH6uQFs169jYyFk6g1yBkFXbxVYy6uS9lXz7GpcuOTjWCB6nBJkZuBmT62uybVYTdDex720te0VvoWbUUr5xNKdH1xO+WEoHtYswPmlxDuqb/XVT7496sES39mclj6Bg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5265.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(316002)(8936002)(110136005)(4326008)(54906003)(71200400001)(83380400001)(38100700002)(52536014)(55016002)(76116006)(5660300002)(8676002)(9686003)(122000001)(86362001)(186003)(45080400002)(26005)(966005)(66556008)(478600001)(7696005)(66446008)(64756008)(33656002)(53546011)(6506007)(2906002)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5thYdJ+ci6pEeM9AWxwfSZ2cz53N/pwbC9eOzt5FaRnagDaRdAhvQ+D/DlHq?= =?us-ascii?Q?DDluKBZX7fEhWioSLieMODYM9uCNIaA63H+gy5nQFEFR2LmftGBIoegNsqjn?= =?us-ascii?Q?aVF9ytqDisT0SAqhEWWUOqxOGxQjyqZ6YT/oATpldApf+YmFu4Uxfs8UslND?= =?us-ascii?Q?63i4NmzCPlpGsO1I2dhbXwNEExj+SRyRN9Wnp3p1QmKqZmtr3t23Gzc5TTBb?= =?us-ascii?Q?DcVBLmo9GVJLB/f58FKujc4PwqMACH5jPyxSe2P0jHaRKNazz+r+EfST9pbC?= =?us-ascii?Q?ZxvSOR4twmKUHrXBapbacA0uV9ZSaXpaBfrE1OPWjeXOZdkGYcwCoKBq3EnW?= =?us-ascii?Q?gtd1keSNcSmEqx2C+ERV1oDMHqaHE6PM0H7a0xUlYXa2mDyXYeUC2NFmJqcY?= =?us-ascii?Q?NGHibWvWYWbq3pPA1rzrBqcUDyiN5YGzP6p0dFumYLIxb3amreIp0f4m/eL2?= =?us-ascii?Q?ifcnefX2yY34xpzEAF6byZlG0ITXRUW1hDyl1hn+L+GvctAqxBCKQyLyQ54p?= =?us-ascii?Q?we8cAzETvr9dbef0uQl6quEWjv8KA5H4eP64PcY4I9ouC3yMJPlUhEUbSC//?= =?us-ascii?Q?x6to4zYUhChK7D1bFK7+78uq0SjnJGnXhdq6Fk2GAVsJccS9w3ifeorAFx3v?= =?us-ascii?Q?Ip8o34DTPG2DYKC0OOqVh/T0hFC0EkyCQSuBuS8BgeX2nFeeuVmA7jtEllrH?= =?us-ascii?Q?hauMTF3ko13LHMQQE8Gzt8WUj/dfcMil7ieCvQVGHQc7Qx1y28DKQ5vxZW/O?= =?us-ascii?Q?tvN19V49fTZMLobn+h9kuNj+qOJy0J1ebJ3taX+fnioaI+2quko3E7qMcOLr?= =?us-ascii?Q?OeJZJD6gdAd8SEOYix56aTZuU0Eh48H1XvWPY4fBqaNc5DwhNcs8OYVK/jDD?= =?us-ascii?Q?ZnBOsdUIM8a0iYggEXYfp+RPn5UIoJgSDDzI6E5yON88Hyo7hCXT8bm0JioC?= =?us-ascii?Q?Gb+mGdD/yxb6ldGEPTXPLZfwUP7SuN7Arfn76BgrnaYOi7QawyMimXgie+65?= =?us-ascii?Q?f7w89+Po4OWlORZmouOS4Z1oCX5zw6VR93mHoELAaRidKpQuzKpt2+cPLlHo?= =?us-ascii?Q?QBQekskilq6Nt+j0TGfuXuhdsHhTRdq67LhKLRErKh5EZsZTkgHwZC/qiFdY?= =?us-ascii?Q?uLvzumqigJNO44wLkW3oXmmRO3qCNSUtS9IzR2Hf/KfdrheLrSKh0mxXFjFV?= =?us-ascii?Q?Xk6a3kZihwNTj7tsSsZtVGJcXiLVW3e7xU6rfnc31SvIOUgk1pS0ppJWgxEH?= =?us-ascii?Q?H9xy5rLI9HVzlQhzn79z+8iMCTzNqK/FxlL4cfS+FTH2ArZzKnuRXnc6v1uz?= =?us-ascii?Q?agYTbaHBemurIWVwf3gDM2pg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5265.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 271473f8-adb6-4dda-13b1-08d91eae031f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 12:18:17.3145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rMXeyfXiDyF0MHibp/TiYxBsY9/X9k3YvHVwN0ehvO3lWK7VD68oFT1UaSe/zdjXzkLowgyd28YY8kKO/6Tb2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5076 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 12:18:20 -0000 [AMD Official Use Only - Internal Distribution Only] Hi, Does anyone have any comments on these patches? A gentle reminder for revie= w. Thanks, Nagajyothi -----Original Message----- From: E, Nagajyothi Sent: Sunday, May 16, 2021 5:06 PM To: Mark Wielaard ; dwz@sourceware.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar ; Parasuraman, H= ariharan ; E, Nagajyothi Subject: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when c= ompiler is clang [AMD Official Use Only - Internal Distribution Only] Hi, This testsuite patch may be used while running make check CC=3D"clang -gdwarf-5" CXX=3D"clang++ -gdwarf-5" to avoid test failures due to readelf. This checks if $CC/$CXX is clang/clang++ and uses llvm-dwarfdump in place o= f readelf in the test scripts. This is needed as readelf produces errors/wa= rnings with clang-generated DWARF5 sections/forms, causing many test failur= es. The latest llvm-dwarfdump (27 April, 2021) is to be used, which has a f= ix in printing headers of DW_UT_partial type. Thanks, Nagajyothi -----Original Message----- From: Mark Wielaard Sent: Thursday, February 18, 2021 8:15 PM To: E, Nagajyothi ; dwz@sourceware.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar Subject: Re: Plan to contribute for supporting split dwarf (-gsplit-dwarf) = in dwz [CAUTION: External Email] Hi Nagajyothi, On Wed, 2021-02-17 at 05:53 +0000, E, Nagajyothi via Dwz wrote: > I am working on adding support for the dwarf5 .debug_str_offsets,=20 > .debug_addr sections and the related forms DW_FORM_strx[1234], DW_FORM_ad= drx[1234]. > Please let me know if anyone has already started work on these. Thanks, I don't believe anybody is working on this right now. There is already a bug for .debug_addr/DW_FORM_addrx[1234] support: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourcew= are.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27375&data=3D04%7C01%7CNagajyo= thi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a8= 2d994e183d%7C0%7C0%7C637492563147320988%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= 7AjB%2BXKo9J5gTlW1CeEhHXZykYKB2vFZ%2BTnBQvW4%2BIA%3D&reserved=3D0 I think this shouldn't be too hard. Any DIE that references an address cann= ot be moved to an alt file, so simply mark it with die_no_multifile. We do = try to optimize DW_AT_low/high_pc attribute pairs, so double check that doe= sn't interfere with DW_FORM_addrx[1234] processing. Also note that there are two new location operations DW_OP_addrx and DW_OP_= constx that can reference the .debug_addr section index. As a followup you could try optimizing things, but then you need to keep tr= ack of all the addresses used and see if there are duplicates that could be= turned into a (smaller) DW_FORM_addrx[1234] index. But I would keep that s= eparate from the initial implementation. For .debug_str_offset/DW_FORM_strx[1234] I opened a new bug. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourcew= are.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27434&data=3D04%7C01%7CNagajyo= thi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a8= 2d994e183d%7C0%7C0%7C637492563147330979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= AqQRLjgKh9h7YHPIr4wDiqP1rRTXz2kG6IZlAT0SaSQ%3D&reserved=3D0 This is a little trickier than DW_FORM_addrx[1234] since such DIEs using DW= _FORM_strx may be moved to a multifile. You also probably want to make them= equal to DW_FORM_strp entries pointing (indirectly) to the same string. You might want to add a note to the the bugs that you are working on them. Thanks, Mark