public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "E, Nagajyothi" <Nagajyothi.E@amd.com>
To: Mark Wielaard <mark@klomp.org>,
	"dwz@sourceware.org" <dwz@sourceware.org>,
	 "vries@gcc.gnu.org" <vries@gcc.gnu.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
	"Achra, Nitika" <Nitika.Achra@amd.com>,
	"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
	"Joseph, Ancel" <Ancel.Joseph@amd.com>,
	"E, Nagajyothi" <Nagajyothi.E@amd.com>
Subject: [PING 7] [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang
Date: Mon, 20 Sep 2021 18:46:48 +0000	[thread overview]
Message-ID: <CH0PR12MB526595289310C13350DA9B8096A09@CH0PR12MB5265.namprd12.prod.outlook.com> (raw)

[Public]

Ping 7... request someone to please review the two patches and give comments.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com> 
Sent: Monday, September 6, 2021 1:07 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org; vries@gcc.gnu.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: [PING] [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[Public]

Ping 6... Please review the patches and give your comments.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Wednesday, August 25, 2021 12:28 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org; vries@gcc.gnu.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: [PING] [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Official Use Only]

Ping 5... gentle reminder to review the patches.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Sunday, July 25, 2021 11:05 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org; vries@gcc.gnu.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: RE: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Public Use]

Ping 4... has anyone looked at these patches?

Request someone to please review the two patches and give comments.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Tuesday, July 13, 2021 9:27 AM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: RE: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Official Use Only - Internal Distribution Only]

Ping 3... any comments on these patches?
If any explanation/clarification is required, I would be glad to provide it. Please let me know.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Thursday, June 3, 2021 10:27 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; Parasuraman, Hariharan <Hariharan.Parasuraman@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: RE: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Official Use Only - Internal Distribution Only]

Ping 2... gentle reminder for review.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Monday, May 24, 2021 5:48 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; Parasuraman, Hariharan <Hariharan.Parasuraman@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: RE: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Official Use Only - Internal Distribution Only]

Hi,

Does anyone have any comments on these patches? A gentle reminder for review.

Thanks,
Nagajyothi

-----Original Message-----
From: E, Nagajyothi <Nagajyothi.E@amd.com>
Sent: Sunday, May 16, 2021 5:06 PM
To: Mark Wielaard <mark@klomp.org>; dwz@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; Parasuraman, Hariharan <Hariharan.Parasuraman@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>
Subject: [PATCH 2/2] Test script modifications to use llvm-dwarfdump when compiler is clang

[AMD Official Use Only - Internal Distribution Only]

Hi,

This testsuite patch may be used while running
	 make check CC="clang -gdwarf-5" CXX="clang++ -gdwarf-5"
to avoid test failures due to readelf.

This checks if $CC/$CXX is clang/clang++ and uses llvm-dwarfdump in place of readelf in the test scripts. This is needed as readelf produces errors/warnings with clang-generated DWARF5 sections/forms, causing many test failures. The latest llvm-dwarfdump (27 April, 2021) is to be used, which has a fix in printing headers of DW_UT_partial type.

Thanks,
Nagajyothi

-----Original Message-----
From: Mark Wielaard <mark@klomp.org>
Sent: Thursday, February 18, 2021 8:15 PM
To: E, Nagajyothi <Nagajyothi.E@amd.com>; dwz@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>
Subject: Re: Plan to contribute for supporting split dwarf (-gsplit-dwarf) in dwz

[CAUTION: External Email]

Hi Nagajyothi,

On Wed, 2021-02-17 at 05:53 +0000, E, Nagajyothi via Dwz wrote:
> I am working on adding support for the dwarf5 .debug_str_offsets, 
> .debug_addr sections and the related forms DW_FORM_strx[1234], DW_FORM_addrx[1234].
> Please let me know if anyone has already started work on these.

Thanks, I don't believe anybody is working on this right now.

There is already a bug for .debug_addr/DW_FORM_addrx[1234] support:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourceware.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27375&amp;data=04%7C01%7CNagajyothi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637492563147320988%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=7AjB%2BXKo9J5gTlW1CeEhHXZykYKB2vFZ%2BTnBQvW4%2BIA%3D&amp;reserved=0
I think this shouldn't be too hard. Any DIE that references an address cannot be moved to an alt file, so simply mark it with die_no_multifile. We do try to optimize DW_AT_low/high_pc attribute pairs, so double check that doesn't interfere with DW_FORM_addrx[1234] processing.

Also note that there are two new location operations DW_OP_addrx and DW_OP_constx that can reference the .debug_addr section index.

As a followup you could try optimizing things, but then you need to keep track of all the addresses used and see if there are duplicates that could be turned into a (smaller) DW_FORM_addrx[1234] index. But I would keep that separate from the initial implementation.

For .debug_str_offset/DW_FORM_strx[1234] I opened a new bug.
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourceware.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27434&amp;data=04%7C01%7CNagajyothi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637492563147330979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=AqQRLjgKh9h7YHPIr4wDiqP1rRTXz2kG6IZlAT0SaSQ%3D&amp;reserved=0

This is a little trickier than DW_FORM_addrx[1234] since such DIEs using DW_FORM_strx may be moved to a multifile. You also probably want to make them equal to DW_FORM_strp entries pointing (indirectly) to the same string.

You might want to add a note to the the bugs that you are working on them.

Thanks,

Mark

                 reply	other threads:[~2021-09-20 18:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR12MB526595289310C13350DA9B8096A09@CH0PR12MB5265.namprd12.prod.outlook.com \
    --to=nagajyothi.e@amd.com \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=Ancel.Joseph@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Nitika.Achra@amd.com \
    --cc=dwz@sourceware.org \
    --cc=mark@klomp.org \
    --cc=vries@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).