From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) by sourceware.org (Postfix) with ESMTPS id C7B19386FC00 for ; Wed, 19 May 2021 17:22:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C7B19386FC00 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S/NSr6klpnUZNdwQzliflWLMbURUevhww9ONogSGKnBi/fjgYlPy6B5TYcGN9+E0VEaAyPpdENxeF3qOcHz8yvDIMb2CLi+du4BlOXUpwI1YynUiVu+D0FPvpoWZqwk5NoePTFXb3XU1aGjU2Ynb1QWasE9e2vsHWQKtPu1BgryUbp+X4BCjTF/GMZFt0OiVnTWzM2vbC3cV9GssM9l2VRgMfzjvW9ek3o0fS+Ck88bx52lb9xuCI5R7oVOqab6O4OqYM1uPdkRjMmKg1eIb8SzgiwyZLh3mxtCA+/SdaSi+YymVW2+UEsZVj0GyDQ55/yWj5wtq6ZHvIELPGkVtVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OzotVlHsqjMa5eJqed7DSoi/9lCMH5mveobY3aLoh8g=; b=i6s74jqsEme7Q7I13KgnSQU57eGNhRpsMedD0FkPI77wq5sN2e1HcHi5ikpkDHjx3HmDC90X8wxBY6uV1BkyB88PZp5ms+ktxuQpbTRy7UTPDqOCH1nFlQjevEY2Je4eHUBGZgb2bEjiglBzvhmeMPo4vovoXrfd49ricO5wEldGI0JVLCRQkWRZ5KX4XsarPRfWpcUEaTVc82wSJhnqa89yXtPsH96Sd87ZZIoLFqpw9F+/T/3cXWGj/6aCXiUHYzy5aLlW2mdHw4idm3ExF0Tk7p3gLq8qC1zI5HVmthPx2cB3Kmq0SWhIFj6mql/+hrS7JNbUjNruRvj3qsoLRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CH0PR12MB5265.namprd12.prod.outlook.com (2603:10b6:610:d0::22) by CH0PR12MB5345.namprd12.prod.outlook.com (2603:10b6:610:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 17:22:36 +0000 Received: from CH0PR12MB5265.namprd12.prod.outlook.com ([fe80::41b7:a794:d2f1:6a8e]) by CH0PR12MB5265.namprd12.prod.outlook.com ([fe80::41b7:a794:d2f1:6a8e%7]) with mapi id 15.20.4129.033; Wed, 19 May 2021 17:22:36 +0000 From: "E, Nagajyothi" To: Mark Wielaard , "dwz@sourceware.org" CC: "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "Parasuraman, Hariharan" , "E, Nagajyothi" Subject: RE: [PATCH 1/2] Support for clang-generated DWARF5 sections .debug_addr/.debug_str_offsets Thread-Topic: [PATCH 1/2] Support for clang-generated DWARF5 sections .debug_addr/.debug_str_offsets Thread-Index: AddKQy9sWJ/KEzkNRZqyamh1YAZr7gCjszLw Date: Wed, 19 May 2021 17:22:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2021-05-19T17:22:25Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=761579c5-dd92-43e5-b76d-09afaa26ddc3; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_justification: I confirm the recipients are approved for sharing this content x-originating-ip: [106.51.142.241] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 324a8445-0ce9-45ef-223e-08d91aeab264 x-ms-traffictypediagnostic: CH0PR12MB5345: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lP+4BgV9FzpoEujyFucniSuyOExII74vXh6Yia+iPLEo3hWeE64tebXQlKtjw7CEoXcFmO/8mmuexZ+2M2XIfh+KtlSLWkNiIGxanqevfeQIoV37ZhGO1gWIrOMvVh0LqBFAbYCKEgmZuAYxly43lvpJk3i7NRLCoIFDFjQ9lYUqhrEEfsxuAfw/v8gT+CuSqThDZ6UqyNifSVsYjIIV4e+GWUmj5XK5OtM+dlowhbP+lRV3okvapPtuVJY605mU+rruU5Am9xth6oKxY1VxDEUjEeq7Ia/14Th7Yz0fj0cQBpPLgcW7x6tlrNUM1NB24qZzHnX79EzfHXUsi+fNeyk5J6RKTxxI1cM110vw4ISzGtT2j14xVfxI+Mx43trGjm9HQyGKpvIFkdxTf9ishqOkOm2KnDytwh6yCztCnL7VbPPpN/x+BfzzHDMjQ6YyBMhMohsbld2LxCvWSRkE2KqRvLnEPz5/OelOl3Z2j1OLTpaJhA9N18Z3/wTBF6ipfAqvpEos+nWhLcfs8BY6nUsy8GEJeRVSwBI6f0eW4H3Su4h8+H/ABEmUHqCeNHRIonTewal8mcazAvFqLfeF5u7wdgwAwjNRcBLZwbmswx6Z6yzYSvgQX915WBRN5hjCCTy/YOJGPw+SNdlnuvl0St3ma1sxK2vumXTEJHdYqvtWdN8sUx30cOGbsX2Q4+vIEXUJeBzqbRwactyCUzZJkK0YshmPZGOVLfDHtBM0Kp4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5265.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(45080400002)(52536014)(478600001)(66556008)(64756008)(66446008)(66476007)(966005)(186003)(5660300002)(33656002)(38100700002)(76116006)(122000001)(66946007)(2906002)(71200400001)(9686003)(8676002)(83380400001)(26005)(4326008)(53546011)(6506007)(86362001)(54906003)(7696005)(55236004)(55016002)(110136005)(316002)(8936002)(142923001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZDPYnwO+CG7AfDDplhQoivHFMo/zVl6pYIKvKyvaVVG7nAiTaCsyRsxP0pge?= =?us-ascii?Q?K4dJRbYebYBzhwT34Av//CKTi09GxeK9/PH6hm2whtHjMigbLIazyrUzpfm0?= =?us-ascii?Q?4LGUKGE+tcAir9DWVxdd6nFfbxp8SIi0elNBo4MHIhB81dSl21MEAb9h1Kap?= =?us-ascii?Q?yIJ/eudzB7hwRiAZhTeQGcS46SzSTULZYQkvWDabuJxjam+1bm9Ef0pQNFrZ?= =?us-ascii?Q?BhOuQPMHTIdgI3JreKhApfxGcxGTFaJhjR5DFAcY1uA62Yhm6zFCYB6tMSKJ?= =?us-ascii?Q?AsbP9E82G8nDlnKymYV1TehPPHtBCuDbEH36H8O4nfGL1UH2afMtW6oCifOX?= =?us-ascii?Q?KVfPVMmrFPjecundjPxQVuGl2iuwXBrvz0GBZq0XwiMOv4f6CI/axb4x6/qU?= =?us-ascii?Q?oHh6+p72F2hysH/ypdFAmFf4oBMZ5Nrf0TtLxFmibNkslras4d0j5Tr0jTxe?= =?us-ascii?Q?SDjZjqXNzw3JsEvq4A073d08EELuTUZsmT3AfXWbMhuwRJJXf+PTRU08ItwM?= =?us-ascii?Q?OP6zvpclG+vmjEs4GkF33DEIKhxlJGiI7so1xH1xfanfF4Bb3okbgL4FYXoX?= =?us-ascii?Q?Te6Oz72slFNm1EFJLMDwxtIgD1XKyCPYgRm85H+d1Tx72Q6YdcOpAFDOadTV?= =?us-ascii?Q?j8KvO0vNTWIMQq22ZpYt6HArUKfQEieu2C1MS1fzYEOla0oDaoVVtlmSSQp1?= =?us-ascii?Q?N76bqs8H1Fh0N8UKxHNu8q6RIByoohj9k+ELBma2upfWpiSH/bYyRAFDbeDH?= =?us-ascii?Q?Z5ZbU8YRT1FLEuJTE40G1Wpsex4auAqNzbjikh30CD99bFu6777UcIvqUhSq?= =?us-ascii?Q?GoEQV0W+X9BuTHNKGKG1RgFYOmNBIyrmEsydV0asj7f7G0n+2ByboWA8kGGe?= =?us-ascii?Q?tlwKbFZNmoTFsmli99cRCWX2mWWvUGRIe8MszDHz7sPqVoWW3a35yN1mb4uU?= =?us-ascii?Q?FUqTrreun8XHHtkLM+cCUNFz2CnUel15knkZw7JfPZxIO9d/vj7E/JrN6nh3?= =?us-ascii?Q?xrQDeFBf8EB+pZ8Le9dCHwSfBACvDOphzBdPC5phqXolZFFZ5qY5CzRRGK9a?= =?us-ascii?Q?yqoaEy20CPZwHjpvptWXhr//eH3m0F2JBhp64Y2slmyAWI0cPYDPV3nM172T?= =?us-ascii?Q?73Fz1FRN/spVzji6nLLL5cjw+RCVbnMpn8dAyxiz7OztXa1ltzkcIaBjUAZb?= =?us-ascii?Q?rKc9iVam7QrMrt44n+DZxtGmW9P7u+S+mpvVqT1y6nfczFoPzD+ykLv4MXUx?= =?us-ascii?Q?1qo8dQp7xxRC7ZICa0zqrsVSVcY8q2Bj1eTkv+MUiER0S0hQkq2t2jNFmovZ?= =?us-ascii?Q?QkVSRVmFy/D9fpRimIMhiqqs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5265.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 324a8445-0ce9-45ef-223e-08d91aeab264 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 17:22:36.4942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h6UnYZZ6OVUHcPghss72VD+Z7LkKWRLIoV0MUelYfOdrzPuwghf7wfE0D12xcMH0D96MpRyajlHsjU5kOzeT/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5345 X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 17:22:41 -0000 [AMD Official Use Only - Internal Distribution Only] Hi, One known issue with this initial patch is that it may not handle string re= ferences of strx[1|2|3|4] forms in partial units from multiple CUs correctl= y. Right now a single cu_str_offsets_base value is recorded with the partia= l unit, from the first encountered DIE. This does not produce failures in t= he testsuite, but may fail with other applications. A proper fix for this w= ill be provided in a subsequent patch. Thanks, Jyothi -----Original Message----- From: E, Nagajyothi Sent: Sunday, May 16, 2021 4:59 PM To: Mark Wielaard ; dwz@sourceware.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar ; E, Nagajyothi = ; Parasuraman, Hariharan Subject: [PATCH 1/2] Support for clang-generated DWARF5 sections .debug_add= r/.debug_str_offsets [AMD Official Use Only - Internal Distribution Only] Hi, Please review and commit the attached patch to support clang-generated DWAR= F5 debug sections .debug_addr and .debug_str_offsets. This patch does not address ODR and multifile support, which will be added = through subsequent patches. Due to this, the ODR tests and cycle.sh of the = testsuite fail during 'make check'. The accompanying testsuite patch may be used while running make check CC=3D"clang -gdwarf-5" CXX=3D"clang++ -gdwarf-5" to avoid test failures due to readelf, as readelf does not support some of = the strx forms generated by clang. Thanks, Nagajyothi -----Original Message----- From: Mark Wielaard Sent: Thursday, February 18, 2021 8:15 PM To: E, Nagajyothi ; dwz@sourceware.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar Subject: Re: Plan to contribute for supporting split dwarf (-gsplit-dwarf) = in dwz [CAUTION: External Email] Hi Nagajyothi, On Wed, 2021-02-17 at 05:53 +0000, E, Nagajyothi via Dwz wrote: > I am working on adding support for the dwarf5 .debug_str_offsets,=20 > .debug_addr sections and the related forms DW_FORM_strx[1234], DW_FORM_ad= drx[1234]. > Please let me know if anyone has already started work on these. Thanks, I don't believe anybody is working on this right now. There is already a bug for .debug_addr/DW_FORM_addrx[1234] support: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourcew= are.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27375&data=3D04%7C01%7CNagajyo= thi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a8= 2d994e183d%7C0%7C0%7C637492563147320988%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= 7AjB%2BXKo9J5gTlW1CeEhHXZykYKB2vFZ%2BTnBQvW4%2BIA%3D&reserved=3D0 I think this shouldn't be too hard. Any DIE that references an address cann= ot be moved to an alt file, so simply mark it with die_no_multifile. We do = try to optimize DW_AT_low/high_pc attribute pairs, so double check that doe= sn't interfere with DW_FORM_addrx[1234] processing. Also note that there are two new location operations DW_OP_addrx and DW_OP_= constx that can reference the .debug_addr section index. As a followup you could try optimizing things, but then you need to keep tr= ack of all the addresses used and see if there are duplicates that could be= turned into a (smaller) DW_FORM_addrx[1234] index. But I would keep that s= eparate from the initial implementation. For .debug_str_offset/DW_FORM_strx[1234] I opened a new bug. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsourcew= are.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D27434&data=3D04%7C01%7CNagajyo= thi.E%40amd.com%7C37c0fb4399464264b01808d8d41bcb9c%7C3dd8961fe4884e608e11a8= 2d994e183d%7C0%7C0%7C637492563147330979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= AqQRLjgKh9h7YHPIr4wDiqP1rRTXz2kG6IZlAT0SaSQ%3D&reserved=3D0 This is a little trickier than DW_FORM_addrx[1234] since such DIEs using DW= _FORM_strx may be moved to a multifile. You also probably want to make them= equal to DW_FORM_strp entries pointing (indirectly) to the same string. You might want to add a note to the the bugs that you are working on them. Thanks, Mark