From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 65F4F3857BAD for ; Thu, 30 Jun 2022 11:47:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65F4F3857BAD Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-222-0zQAQ5wtO8iaiRSBBVlZkg-1; Thu, 30 Jun 2022 07:47:13 -0400 X-MC-Unique: 0zQAQ5wtO8iaiRSBBVlZkg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A39E785A580; Thu, 30 Jun 2022 11:47:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 646012166B29; Thu, 30 Jun 2022 11:47:13 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25UBlAKU4006924 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 13:47:11 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25UBlATN4006923; Thu, 30 Jun 2022 13:47:10 +0200 Date: Thu, 30 Jun 2022 13:47:09 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] Mark and init shstrtab[_len] and const in optimize_multifile Message-ID: Reply-To: Jakub Jelinek References: <20220630113455.30700-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20220630113455.30700-1-mark@klomp.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 11:47:16 -0000 On Thu, Jun 30, 2022 at 01:34:55PM +0200, Mark Wielaard wrote: > Old gcc (4.8.5) warn that shstrtab and shstrtab_len can be clobbered > by the longjump. Work around that by marking shstrtab_gnu and > shstrtab_dwarf5 as static and shstrtab and shstrtab_len as const. > Init shstrtab and shstrtab_len at declaration. > > * dwz.c (optimize_multifile): Make shstrtab_[gnu|dwarf5], > shstrtab[_len] static. shstrtab[_len] init and make const. > - const char *shstrtab; > - size_t shstrtab_len; > + const char *shstrtab = dwarf_5 ? shstrtab_dwarf5 : shstrtab_gnu; You aren't marking shstrtab as const though, that would be const char *const shstrtab = ... Otherwise LGTM. Jakub