public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Lv Ying <lvying6@huawei.com>
Cc: tdevries@suse.de, jakub@redhat.com, dwz@sourceware.org,
	fanwentao@huawei.com
Subject: Re: [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)
Date: Sat, 25 Jun 2022 23:12:08 +0200	[thread overview]
Message-ID: <Yrd6KIaVigixlJeY@wildebeest.org> (raw)
In-Reply-To: <1642022984-19556-1-git-send-email-lvying6@huawei.com>

Hi,

On Thu, Jan 13, 2022 at 05:29:44AM +0800, Lv Ying via Dwz wrote:
> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
> 
> fix the new -Wn readelf flag test

Thanks so much for this patch. And appologies it took so long to
review.

As the commit message says this fixes two failing testcases for me,
odr-struct-multifile.sh and cycle.sh.

And it looks totally correct, even if there are releases of readelf
which put a ',' after "-Wn" it should still work.

Pushed your patch.

Cheers,

Mark


      parent reply	other threads:[~2022-06-25 21:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 21:29 Lv Ying
2022-01-17  7:44 ` lvying
2022-06-25 21:12 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrd6KIaVigixlJeY@wildebeest.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=fanwentao@huawei.com \
    --cc=jakub@redhat.com \
    --cc=lvying6@huawei.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).