From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 7E4CA385C316 for ; Sat, 25 Jun 2022 21:12:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E4CA385C316 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 3DC76300026A; Sat, 25 Jun 2022 23:12:09 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 87FC62E833F4; Sat, 25 Jun 2022 23:12:08 +0200 (CEST) Date: Sat, 25 Jun 2022 23:12:08 +0200 From: Mark Wielaard To: Lv Ying Cc: tdevries@suse.de, jakub@redhat.com, dwz@sourceware.org, fanwentao@huawei.com Subject: Re: [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e) Message-ID: References: <1642022984-19556-1-git-send-email-lvying6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1642022984-19556-1-git-send-email-lvying6@huawei.com> X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2022 21:12:12 -0000 Hi, On Thu, Jan 13, 2022 at 05:29:44AM +0800, Lv Ying via Dwz wrote: > The two testcases still failed when using newer readelf(binutils commit c46b706620e): > testsuite/dwz.tests/odr-struct-multifile.sh > testsuite/dwz.tests/cycle.sh > > fix the new -Wn readelf flag test Thanks so much for this patch. And appologies it took so long to review. As the commit message says this fixes two failing testcases for me, odr-struct-multifile.sh and cycle.sh. And it looks totally correct, even if there are releases of readelf which put a ',' after "-Wn" it should still work. Pushed your patch. Cheers, Mark