dwz testsuite patch: version tagging

dwz testsuite patch: version tagging

[Frank Ch. Eigler]

Hi -

The following little obvious patch adds the usual dejagnu trailer to
the .log/.sum files.  Wonder if people would be interested in adding
more tracing to the test cases, so the .log file is not so bare.
Maybe just execute all the subtest .sh files with "sh -x" and verbose-log
their output?

- FChE


diff --git a/testsuite/config/default.exp b/testsuite/config/default.exp
index e69de29bb2d1..16785528e489 100644
--- a/testsuite/config/default.exp
+++ b/testsuite/config/default.exp
@@ -0,0 +1,8 @@
+
+
+
+proc dwz_version {} {
+  set location [exec /usr/bin/which dwz]
+  regexp {version [0-9.]*} [exec dwz --version 2>@ stdout] version
+  clone_output "$location $version"
+}

Re: dwz testsuite patch: version tagging

[Mark Wielaard]

Hi Frank,

On Wed, 2022-07-06 at 12:45 -0400, Frank Ch. Eigler via Dwz wrote:
> The following little obvious patch adds the usual dejagnu trailer to
> the .log/.sum files.

So for me this adds:
/opt/local/src/dwz/testsuite-bin/dwz version 0.14
to the end of dwz.log and dwz.sum

Which is "correct" but also not that useful imho.

It is correct in that make check will create that directory copy a dwz
executable there, run the tests and delete that directory and test
binary again.

It is not that useful because the version string isn't really enough to
know what was being tested. It would be nice if it could include the
top of git hash for example.

Not against adding more info to the dwz.log/sum files though.

Cheers,

Mark

> 
> diff --git a/testsuite/config/default.exp
> b/testsuite/config/default.exp
> index e69de29bb2d1..16785528e489 100644
> --- a/testsuite/config/default.exp
> +++ b/testsuite/config/default.exp
> @@ -0,0 +1,8 @@
> +
> +
> +
> +proc dwz_version {} {
> +  set location [exec /usr/bin/which dwz]
> +  regexp {version [0-9.]*} [exec dwz --version 2>@ stdout] version
> +  clone_output "$location $version"
> +}

Re: dwz testsuite patch: version tagging

[Frank Ch. Eigler]

Hi -

> So for me this adds:
> /opt/local/src/dwz/testsuite-bin/dwz version 0.14
> to the end of dwz.log and dwz.sum
> 
> Which is "correct" but also not that useful imho.
> [...]
> It is not that useful because the version string isn't really enough to
> know what was being tested. It would be nice if it could include the
> top of git hash for example.

One solution to that is to compile the git-hash into the dwz binary
itself, just like we do with systemtap (git_version.sh etc.).  Then
dwz --version would report that version too, and this bit of dejagnu
code would capture it.


- FChE