public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Michael Matz <matz@suse.de>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, jakub@redhat.com
Subject: Re: [RFC 1/13][odr] Cover letter
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.21.1912101736100.29201@wotan.suse.de> (raw)
In-Reply-To: <20191210171830.GA13804@delia>

Hello,

On Tue, 10 Dec 2019, Tom de Vries wrote:

> This patch series adds optimization option --odr, that exploits the
> one-definition-rule for C++ for struct, class and union.  It's on by
> default.
... 
> Any comments?

Like Yeehah!?  :-)

Seriously, this is nice.  The additional reduction of using the ODR rule 
on cc1 isn't as big as I thought in the past, probably the largest stuff 
in .debug_info aren't type descriptions anymore, but still, it's a 22% 
reduction on top, so nothing to sneeze at.  (Maybe for firefox it's more, 
I remember Honza moaning about many multiple struct type chains that 
only differed in the completeness of their pointer members)


Ciao,
Michael.

  reply	other threads:[~2019-12-10 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 Tom de Vries
2019-01-01  0:00 ` Michael Matz [this message]
2019-01-01  0:00   ` Tom de Vries
2019-01-01  0:00     ` Michael Matz
2019-01-01  0:00       ` Tom de Vries
2019-01-01  0:00         ` Michael Matz
2019-01-01  0:00   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.1912101736100.29201@wotan.suse.de \
    --to=matz@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).