From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43491 invoked by alias); 11 Dec 2019 13:15:57 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 43482 invoked by uid 89); 11 Dec 2019 13:15:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Honza, explanations, HX-Languages-Length:1520, letter X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Michael Matz To: Tom de Vries cc: dwz@sourceware.org, jakub@redhat.com Subject: Re: [RFC 1/13][odr] Cover letter In-Reply-To: Message-ID: References: <20191210171830.GA13804@delia> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2019-q4/txt/msg00143.txt.bz2 Hello, On Tue, 10 Dec 2019, Tom de Vries wrote: > > Seriously, this is nice. The additional reduction of using the ODR rule > > on cc1 isn't as big as I thought in the past, probably the largest stuff > > in .debug_info aren't type descriptions anymore, but still, it's a 22% > > reduction on top, so nothing to sneeze at. (Maybe for firefox it's more, > > I remember Honza moaning about many multiple struct type chains that > > only differed in the completeness of their pointer members) > > I'd hope that the --odr-mode=unify in a future patch series will bring > further improvement, but we'll have to see how much. > > As for this patch series, I'm planning to commit in a couple of days, > unless there are serious objections. > > Could you at least review the user visible parts? Command line option > names, man page entries (and usage ... oops, I forgot to update usage). If you mean me: I'm fine with the names, but would expand a little bit on the explanations. For --odr I would add a sentence describing the effect of applying the ODR rule (without going into too much detail), i.e. mention that this causes type DIEs that have to be the same per C++ rules (same name basically) to be more forcefully deduped. Also a description of the two modes basic/link might be in order for the user to make a meaningful choice; alteratively describe it as debug/development option if the user isn't supposed to use it in regular use. Otherwise I have no comments. Ciao, Michael.