From: Tom de Vries <tdevries@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org, Michael Matz <matz@suse.de>
Subject: Branch creation: dwz-0.13-branch
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <b1d71d1f-7767-3ca9-6c4e-2e005968d6fa@suse.de> (raw)
In-Reply-To: <e27d7f91-33ce-96b6-c714-5c15d1e23e8e@suse.de>
[ was: Re: [committed] Update --version copyright message ]
On 16-08-19 11:58, Tom de Vries wrote:
> [ was: Re: [PATCH] Add do-release.sh ]
>
> On 12-08-19 17:18, Tom de Vries wrote:
>> On 29-07-19 19:20, Jakub Jelinek wrote:
>>> On Mon, Jul 22, 2019 at 09:41:33AM +0200, Tom de Vries wrote:
>>>> Hi,
>>>>
>>>> this commit adds a script that:
>>>> - bumps either the minor or the major version, using options
>>>> --major or --minor
>>>> - updates VERSION
>>>> - commits VERSION update
>>>> - tags VERSION update
>>>>
>>>> OK for trunk?
>>>>
>>>> Is there anything else involved in doing a release?
>>>
>>> I think that is all, bumping VERSION, commiting and tagging was all I did in
>>> the past.
>>>
>>> One thing that might be worth doing is bump copyright years on files you've
>>> modified, I know dwz.c has been using mostly Red Hat copyright, if you want
>>> to use say FSF copyright, can you change that 2003 in there to 2003, 2019?
>>> Or do you want to use SUSE copyright instead?
>>> I guess because I have touched dwz.c last year the RH copyright should be
>>> -2018 instead of -2015 too, and dwarf2.def should be probably changed to
>>> 1992-2018 FSF copyright, using the simple range. After the release we
>>> should likely import new dwarf2.def and dwarf2.h from GCC tree.
>>
>> Hmm, something I overlooked:
>> ...
>> $ ./dwz --version
>> dwz version 0.13
>> Copyright (C) 2001-2012 Red Hat, Inc.
>> Copyright (C) 2003 Free Software Foundation, Inc.
>> ...
>>
>> We've updated the copyright in the file headers, but not in the version
>> message.
>>
>> Patch below fixes this, updating the message using the copyright from
>> the dwz.c file header.
>>
>> I wonder though, what about the copyright in the other files:
>> dwarf2.def, dwarf2.h, dwarfnames.c, hashtab.c, hashtab.h, sha1.c and
>> sha1.h? Should we take the copyright in those files into account as
>> well? Or is it just dwz.c that matters?
>
> I've written a script that:
> - extracts copyright lines from the source files,
> - merges them, and
> - writes out define flags to a new file COPYRIGHT_YEARS.
>
> The version message now uses those defines.
Unfortunately, due to the master commit "Copy dwarf2.def, dwarf2.h and
dwarfnames.c from gcc", the master commit fixing the --version message
cannot be backported verbatim to 0.13 , but requires a rerun of
gen-copyright-years.sh.
It makes sense to have a dwz-0.13 branch to record this backport, which
can then be used verbatim in the various packages.
So, I've created a branch dwz-0.13-branch based on tag dwz-0.13.
Thanks,
- Tom
next prev parent reply other threads:[~2019-08-16 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [PATCH] Add do-release.sh Tom de Vries
2019-01-01 0:00 ` Jakub Jelinek
2019-01-01 0:00 ` [committed] Copy dwarf2.def, dwarf2.h and dwarfnames.c from gcc Tom de Vries
2019-01-01 0:00 ` [PATCH] Add do-release.sh Tom de Vries
2019-01-01 0:00 ` [committed] Update --version copyright message Tom de Vries
2019-01-01 0:00 ` Tom de Vries [this message]
2019-01-01 0:00 ` [PATCH] Add do-release.sh Tom de Vries
2019-01-01 0:00 ` Jakub Jelinek
2019-01-01 0:00 ` Tom de Vries
2019-01-01 0:00 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d71d1f-7767-3ca9-6c4e-2e005968d6fa@suse.de \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).