From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id D25EE3842427 for ; Fri, 26 Feb 2021 13:25:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D25EE3842427 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3D0CAE07; Fri, 26 Feb 2021 13:25:57 +0000 (UTC) Subject: Re: [PATCH] Document experimental status of odr To: Mark Wielaard Cc: dwz@sourceware.org, jakub@redhat.com References: <20210225161730.GA9458@delia> <20210226130453.GE3014@wildebeest.org> From: Tom de Vries Message-ID: Date: Fri, 26 Feb 2021 14:25:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226130453.GE3014@wildebeest.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 13:26:00 -0000 On 2/26/21 2:04 PM, Mark Wielaard wrote: > Hi Tom, > > On Thu, Feb 25, 2021 at 05:17:31PM +0100, Tom de Vries wrote: >> Add documentation of the experimental status of the odr optimization in dwz.1. >> >> Any comments? >> >> >> PR dwz/27401 >> * dwz.1: Document experimental status of odr. > > Looks good to me. > Thanks for the review. > BTW. Do you already know when would you consider it no longer > experimental? Are there still fundemental bugs/design issues With the current state of trunk + recently submitted odr fixes there are no longer any known bugs in odr. The only design issue that I can think of is that it's disabled for low-mem (listed in set_die_odr_state as todo). > or is it > now just having people experiment with it and finding bugs? That as well. [ FWIW, I've unofficially labeled a recent commit as 0.14-rc1 and am in the process of bringing that + submitted odr fixes to tumbleweed, with odr enabled by default. So, I expect some feedback there ... ;) ] To come back to your question, the label experimental is to warn the user that it can be used, but expect problems. So I'd say once we fix the initially reported problems and figure out the low-mem thingy, we can drop the experimental label. Thanks, - Tom