On 14-02-19 10:38, Tom de Vries wrote:
> Hi,
> > Function read_exprloc contains a loop that marks all parents of a
> DW_OP_GNU_parameter_ref reference with CK_BAD.  The loop however has no
> private loop variable, so the ref variable, initially pointing to the
> referenced DIE, ends up after the loop pointing to the root parent of the
> reference instead.  Consequently, the code after the loop, intended to be
> executed for the referenced DIE, is instead executed for the root parent of
> the referenced DIE.
> 
> Fix this by moving the loop alap.
> 

This updated patch introduces a private loop variable instead.

Also, the rationale now contains a more elaborate analysis of the PR.

Committed as below.

Thanks,
- Tom