From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-49-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 40458 invoked by alias); 27 Feb 2019 09:46:40 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 40371 invoked by uid 48); 27 Feb 2019 09:46:36 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24275] hardlink handling leaves temporary file if not
 file compressed
Date: Tue, 01 Jan 2019 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-24275-11298-CyIUUt1QqM@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-24275-11298@http.sourceware.org/bugzilla/>
References: <bug-24275-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q1/txt/msg00048.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D24275

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at redhat dot com

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
AFAIU, the problem originates from the fact that the dedicated handling for
this case in the dwz function:
...
          /* If a hardlink to this has been processed before=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
             and we didn't change it, just assume the same=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
             state.  */
          if (resa[n].res =3D=3D 1)
            {
              close (fd);
              res->res =3D -2;
              return 1;
            }
...
is not triggered  when called with b.out argument because this code at the =
end
of dwz:
...
  free (dso);
  if (ret =3D=3D 0 && !low_mem)
    res->res =3D 0;
  return ret;
...
sets resa[n].res to 0 when called with a.out argument, irregardless of whet=
her
a.out was changed or not.

--=20
You are receiving this mail because:
You are on the CC list for the bug.