* [Bug default/24277] New: dwz needs testsuite
@ 2019-01-01 0:00 vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24277] " mark at klomp dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
Bug ID: 24277
Summary: dwz needs testsuite
Product: dwz
Version: unspecified
Status: NEW
Severity: enhancement
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
With dwz bugs like:
- PR24274 "low-mem files processed in multifile mode"
- PR24275 "hardlink handling leaves temporary file if not file compressed"
it becomes clear that we need a dwz testsuite, to:
- be able to add tests to patches fixing those PRs to verify that they're fixed
- check that patches fixing those PRs don't break other behaviour
The gdb testsuite contains two dwz test modes in conjunction with
target_board=cc-with-tweaks:
- CC_WITH_TWEAKS_FLAGS='-z' (regular dwz)
- CC_WITH_TWEAKS_FLAGS='-m' ()
but that tests just the dwarf output, and uses dwz in a limited amount of ways.
It's debatable whether we want to add (possibly large) executables to the
testsuite to test assert fixes which are typically not triggered with hello
world type examples.
But adding hello world type examples should be possible, and for that we need
some testsuite infrastructure.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug default/24277] dwz needs testsuite
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` mark at klomp dot org
2019-01-01 0:00 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mark at klomp dot org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
You might want to look at (steal) the DWARF assembler from the GDB testsuite.
See gdb/testsuite/lib/dwarf.exp. There are various examples in the
gdb/testsuite/gdb.dwarf2/ directory that use Dwarf::assemble to create a small
assembly files that can then be compiled into an ELF testfile containing
various DWARF sections.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug default/24277] dwz needs testsuite
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24277] " mark at klomp dot org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at redhat dot com
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #1)
> Created attachment 11654 [details]
> Tentative patch
Jakub,
Is there a specific style of testsuite that you want, f.i. dejagnu or automake?
If not, do you want some form PASS/FAIL/TOTAL reporting added?
Any other comments?
Otherwise, is this OK?
Thanks,
- Tom
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug default/24277] dwz needs testsuite
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24277] " mark at klomp dot org
2019-01-01 0:00 ` vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` jakub at redhat dot com
2019-01-01 0:00 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 11654
--> https://sourceware.org/bugzilla/attachment.cgi?id=11654&action=edit
Tentative patch
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/24277] dwz needs testsuite
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
` (2 preceding siblings ...)
2019-01-01 0:00 ` vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` jakub at redhat dot com
2019-01-01 0:00 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at redhat dot com @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
--- Comment #3 from Jakub Jelinek <jakub at redhat dot com> ---
I guess either either dejagnu or automake is fine. Indeed, cc-with-tweaks gdb
testing should hopefully catch more, because it actually uses the debug info,
but there is a problem with gdb testsuite being sometimes a little bit flakey.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug default/24277] dwz needs testsuite
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
` (3 preceding siblings ...)
2019-01-01 0:00 ` jakub at redhat dot com
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24277
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=dwz.git;a=commit;h=abb14a9e31b093a0e0abf9fdd65d213575ac9bef
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-01 19:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 0:00 [Bug default/24277] New: dwz needs testsuite vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24277] " mark at klomp dot org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` jakub at redhat dot com
2019-01-01 0:00 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).