* [Bug default/24407] New: comment in partition_dups_1 does not match code
@ 2019-01-01 0:00 vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24407] " vries at gcc dot gnu.org
0 siblings, 1 reply; 2+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24407
Bug ID: 24407
Summary: comment in partition_dups_1 does not match code
Product: dwz
Version: unspecified
Status: NEW
Severity: minor
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
In partition_dups_1 there's some code:
...
if (second_phase)
{
dw_die_ref next;
for (k = i; k < j; k++)
{
if (arr[k]->die_dup != NULL)
continue;
for (ref = arr[k]; ref; ref = next)
{
dw_cu_ref refcu = die_cu (ref);
next = ref->die_nextdup;
ref->die_dup = NULL;
ref->die_nextdup = NULL;
ref->die_remove = 0;
/* If there are dups within a single CU
(arguably a bug in the DWARF producer),
keep them linked together, but don't link
DIEs across different CUs. */
while (next && refcu == die_cu (next))
{
dw_die_ref cur = next;
next = cur->die_nextdup;
cur->die_dup = ref;
cur->die_nextdup = ref->die_nextdup;
ref->die_nextdup = cur;
}
}
}
}
...
If we have DIEs linked across 2 different CUs, indeed this code breaks the
link.
But if we have DIES linked across 3 different CUs, then this code breaks the
link between the first and the second, but not between the second and the
third.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug default/24407] comment in partition_dups_1 does not match code
2019-01-01 0:00 [Bug default/24407] New: comment in partition_dups_1 does not match code vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
0 siblings, 0 replies; 2+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24407
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WORKSFORME
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Sorry, after more debugging, I realize I misunderstood the code.
[ Perhaps factoring out the two inner loops into an unlinks_dups function would
make things a bit more readable for me. ]
Marking as resolved-worksforme.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-01 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 0:00 [Bug default/24407] New: comment in partition_dups_1 does not match code vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24407] " vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).