From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-170-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 68903 invoked by alias); 1 Apr 2019 12:36:37 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <dwz.sourceware.org>
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 63637 invoked by uid 48); 1 Apr 2019 12:36:34 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24407] New: comment in partition_dups_1 does not match
 code
Date: Tue, 01 Jan 2019 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: minor
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-24407-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q2/txt/msg00002.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D24407

            Bug ID: 24407
           Summary: comment in partition_dups_1 does not match code
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

In partition_dups_1 there's some code:
...
      if (second_phase)
        {
          dw_die_ref next;
          for (k =3D i; k < j; k++)
            {
              if (arr[k]->die_dup !=3D NULL)
                continue;
              for (ref =3D arr[k]; ref; ref =3D next)
                {
                  dw_cu_ref refcu =3D die_cu (ref);
                  next =3D ref->die_nextdup;
                  ref->die_dup =3D NULL;
                  ref->die_nextdup =3D NULL;
                  ref->die_remove =3D 0;
                  /* If there are dups within a single CU
                     (arguably a bug in the DWARF producer),
                     keep them linked together, but don't link
                     DIEs across different CUs.  */
                  while (next && refcu =3D=3D die_cu (next))
                    {
                      dw_die_ref cur =3D next;
                      next =3D cur->die_nextdup;
                      cur->die_dup =3D ref;
                      cur->die_nextdup =3D ref->die_nextdup;
                      ref->die_nextdup =3D cur;
                    }
                }
            }
        }
...

If we have DIEs linked across 2 different CUs, indeed this code breaks the
link.

But if we have DIES linked across 3 different CUs, then this code breaks the
link between the first and the second, but not between the second and the
third.

--=20
You are receiving this mail because:
You are on the CC list for the bug.