public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug gdb/24438] new regressions with dwz -m
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <bug-24438-11298-mhhjUXYZHb@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-24438-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=24438

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6892f60143f7809641dc1824e29dcc406a705df6

commit 6892f60143f7809641dc1824e29dcc406a705df6
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Apr 23 15:35:21 2019 +0200

    [gdb/contrib] Remove superfluous .alt file after dwz invocation in
cc-with-tweaks.sh

    The -m option of cc-with-tweaks.sh sets want_multi to true, invoking dwz
like
    this:
    ...
    elif [ "$want_multi" = true ]; then
        cp $output_file ${output_file}.alt
        $DWZ -m ${output_file}.dwz "$output_file" ${output_file}.alt \
            > /dev/null 2>&1
    fi
    ...

    The problem that is being solved here, is that we want to test dwz in
    multifile mode, which requires more than one input file, while we only have
    (at the scope of cc-with-tweaks.sh) one executable.  We handle this by
copying
    the executable and offering this as a second input (and using a copy has
the
    additional benefit that it maximally enables dwz transformation).

    However, after the dwz invocation, the copy is no longer used, and the
    presence of the file actually causes a test regression:
    ...
    FAIL: gdb.base/jit-so.exp: test jit-reader-load filename completion
    ...

    Fix this by removing the superflous copy after dwz invocation.

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2019-04-23  Tom de Vries  <tdevries@suse.de>

        PR gdb/24438
        * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
        invocation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2019-04-23 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 [Bug default/24438] New: " vries at gcc dot gnu.org
2019-01-01  0:00 ` [Bug gdb/24438] " vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` cvs-commit at gcc dot gnu.org [this message]
2019-01-01  0:00 ` [Bug default/24438] " vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` [Bug gdb/24438] " vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` [Bug default/24438] " vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24438-11298-mhhjUXYZHb@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).