From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24468] dwz -m generates partial unit without import
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-24468-11298-q51dWy14It@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-24468-11298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=24468
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #1)
> So, what happens is this: the partial unit at 2b5 in the multifile contains
> as first die:
> ...
> <1><2be>: Abbrev Number: 5 (DW_TAG_const_type)
> <2bf> DW_AT_type : <0x4c>
> ...
> which refers to:
> ...
> <1><4c>: Abbrev Number: 18 (DW_TAG_typedef)
> <4d> DW_AT_name : (indirect string, offset: 0x54c): size_t
> <51> DW_AT_decl_file : 1
> <52> DW_AT_decl_line : 216
> <53> DW_AT_type : <0x344>
> ...
> in another partial unit in the multifile.
>
> When matching dies in the input file against the dies in the multifile
> during finalize_multifile, we compare 2be to 394:
> ...
> <1><389>: Abbrev Number: 24 (DW_TAG_typedef)
> <38a> DW_AT_name : (indirect string, offset: 0x226): size_t
> <38e> DW_AT_decl_file : 2
> <38f> DW_AT_decl_line : 216
> <390> DW_AT_type : <0x14>
> <1><394>: Abbrev Number: 7 (DW_TAG_const_type)
> <395> DW_AT_type : <0x389>
> ...
> which then fails because of a mismatch in DW_FORM (DW_FORM_ref_addr vs
> DW_FORM_ref_udata).
>
which is fixed by:
...
diff --git a/dwz.c b/dwz.c
index 8ea7c4d..93532b9 100644
--- a/dwz.c
+++ b/dwz.c
@@ -3161,7 +3161,7 @@ die_eq_1 (dw_cu_ref cu1, dw_cu_ref cu2,
switch (form1)
{
case DW_FORM_ref_addr:
- if (likely (!op_multifile && !rd_multifile))
+ if (likely (!op_multifile && !rd_multifile && !fi_multifile))
{
if (form1 != form2)
FAIL;
@@ -3176,7 +3176,7 @@ die_eq_1 (dw_cu_ref cu1, dw_cu_ref cu2,
switch (form2)
{
case DW_FORM_ref_addr:
- if (likely (!op_multifile && !rd_multifile))
+ if (likely (!op_multifile && !rd_multifile && !fi_multifile))
FAIL;
break;
case DW_FORM_ref_udata:
...
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2019-04-22 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [Bug default/24468] New: " vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24468] " vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-24468-11298-q51dWy14It@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).