From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-195-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 54048 invoked by alias); 22 Apr 2019 13:26:09 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <dwz.sourceware.org>
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 54001 invoked by uid 48); 22 Apr 2019 13:26:06 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24468] dwz -m generates partial unit without import
Date: Tue, 01 Jan 2019 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-24468-11298-zmwYMD1sQM@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-24468-11298@http.sourceware.org/bugzilla/>
References: <bug-24468-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q2/txt/msg00027.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D24468

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> ...
> diff --git a/dwz.c b/dwz.c
> index 8ea7c4d..93532b9 100644
> --- a/dwz.c
> +++ b/dwz.c
> @@ -3161,7 +3161,7 @@ die_eq_1 (dw_cu_ref cu1, dw_cu_ref cu2,
>        switch (form1)
>         {
>         case DW_FORM_ref_addr:
> -         if (likely (!op_multifile && !rd_multifile))
> +         if (likely (!op_multifile && !rd_multifile && !fi_multifile))
>             {
>               if (form1 !=3D form2)
>                 FAIL;
> @@ -3176,7 +3176,7 @@ die_eq_1 (dw_cu_ref cu1, dw_cu_ref cu2,
>           switch (form2)
>             {
>             case DW_FORM_ref_addr:
> -             if (likely (!op_multifile && !rd_multifile))
> +             if (likely (!op_multifile && !rd_multifile && !fi_multifile=
))
>                 FAIL;
>               break;
>             case DW_FORM_ref_udata:
> ...

Interestingly, the code following this that forces handling unequal DW_FORMs
has the same condition:
...
        case DW_FORM_ref_addr:
          if (likely (!op_multifile && !rd_multifile && !fi_multifile))
            {
              ptr1 +=3D cu1->cu_version =3D=3D 2 ? ptr_size : 4;
              ptr2 +=3D cu2->cu_version =3D=3D 2 ? ptr_size : 4;
              break;
            }
          /* FALLTHRU */
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.