[Bug default/24823] [dwz] Bad DW_OP_GNU_variable_value DIE

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=24823

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at redhat dot com,
                   |                            |mark at klomp dot org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Given that the DW_OP_GNU_variable_value is similar to DW_FORM_ref_addr, and
does normally not point into other files ( the exception being some old ada
compiler, see http://eagercon.com/dwarf/issues/010322-2.htm ), there's no way
to reach the multifile from the original file.

So the fix is to forbid DW_OP_GNU_variable_value-referenced DIEs to move to the
multifile:
...
diff --git a/dwz.c b/dwz.c
index e5de164..577ea2c 100644
--- a/dwz.c
+++ b/dwz.c
@@ -1596,6 +1596,7 @@ read_exprloc (DSO *dso, dw_die_ref die, unsigned char
*ptr, size_t len,
                     dso->filename, get_DW_OP_str (op));
              return 1;
            }
+         ref->die_no_multifile = 1;
          if (unlikely (low_mem))
            {
              ref->die_referenced = 1;
...

[ AFAIU, the DIEs could move together to the multifile, but I don't know of any
current mechanism to enforce two DIEs to be either both moved to the multifile,
or both not moved to the multifile. ]

-- 
You are receiving this mail because:
You are on the CC list for the bug.