public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25024] dwz: Multifile temporary files too large
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <bug-25024-11298-4t1cC6N2H3@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25024-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25024

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #9)
> There are a few things to mention here:
> - there is no clear reason why this should be an error, we could also warn
>   about not being able to add to the temporary files, and continue the
>   multifile optimization

I ran this again using --devel-trace to get a bit more information, and found
out that actually there's no error.  The "dwz: Multifile temporary files too
large" message is a warning, telling the user in a _very_ indirect way that dwz
switches off multifile optimization and will continue to process the remaining
files in single-file mode.

This is part of a larger issue in dwz where both warnings and errors are
generated using a call to 'error', and consequently it's not immediately clear
from the source code which is an error and which is a warning.

Furthermore, in write_multifile when running into this warning we immediately
return with return value 1, suggesting that processing is stopped, but the
return value is actually ignored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2019-11-29  9:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 [Bug default/25024] New: " jan.kratochvil at redhat dot com
2019-01-01  0:00 ` [Bug default/25024] " vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org [this message]
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` jan.kratochvil at redhat dot com
2019-01-01  0:00 ` jan.kratochvil at redhat dot com
2019-01-01  0:00 ` jan.kratochvil at redhat dot com
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` jan.kratochvil at redhat dot com
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25024-11298-4t1cC6N2H3@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).