public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/25229] Add input verification phase
  2019-01-01  0:00 [Bug default/25229] New: Add input verification phase vries at gcc dot gnu.org
@ 2019-01-01  0:00 ` vries at gcc dot gnu.org
  2021-03-12 10:56 ` vries at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01  0:00 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=25229

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch in attachment 11587 has a type of verification phase.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/25229] New: Add input verification phase
@ 2019-01-01  0:00 vries at gcc dot gnu.org
  2019-01-01  0:00 ` [Bug default/25229] " vries at gcc dot gnu.org
  2021-03-12 10:56 ` vries at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01  0:00 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=25229

            Bug ID: 25229
           Summary: Add input verification phase
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

I've just committed a fix for PR24169, which makes dwz generate an error for a
certain type of invalid dwarf, in this case an invalid DW_FORM_ref_addr
reference.

The fix follows the just-in-time style of the implementation in the sense that
it generates the error when and where it encounters it, in this case in
write_die.

There are a number of problem with this approach:
- errors are not detected reliably: if dwz decides that it's not a good idea to
  optimize the file, it will not report an error, because we never get to
  write_die. 
- the error may have to be handled in more than one location.
- it may take relatively long before the error is detected.

The fix for this is to have a verify phase (before or in combination with
read_debug_info). Such a phase would obviously add more processing time, so it
would be good to have the user to be able to switch that on or off.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/25229] Add input verification phase
  2019-01-01  0:00 [Bug default/25229] New: Add input verification phase vries at gcc dot gnu.org
  2019-01-01  0:00 ` [Bug default/25229] " vries at gcc dot gnu.org
@ 2021-03-12 10:56 ` vries at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-12 10:56 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=25229

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27568


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27568
[Bug 27568] Add initial .debug_info reading phase to dwz
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-12 10:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01  0:00 [Bug default/25229] New: Add input verification phase vries at gcc dot gnu.org
2019-01-01  0:00 ` [Bug default/25229] " vries at gcc dot gnu.org
2021-03-12 10:56 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).