From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113161 invoked by alias); 28 Nov 2019 12:29:01 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 113114 invoked by uid 48); 28 Nov 2019 12:28:57 -0000 From: "vries at gcc dot gnu.org" To: dwz@sourceware.org Subject: [Bug default/25229] New: Add input verification phase Date: Tue, 01 Jan 2019 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: dwz X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: nobody at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2019-q4/txt/msg00093.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D25229 Bug ID: 25229 Summary: Add input verification phase Product: dwz Version: unspecified Status: NEW Severity: enhancement Priority: P2 Component: default Assignee: nobody at sourceware dot org Reporter: vries at gcc dot gnu.org CC: dwz at sourceware dot org Target Milestone: --- I've just committed a fix for PR24169, which makes dwz generate an error fo= r a certain type of invalid dwarf, in this case an invalid DW_FORM_ref_addr reference. The fix follows the just-in-time style of the implementation in the sense t= hat it generates the error when and where it encounters it, in this case in write_die. There are a number of problem with this approach: - errors are not detected reliably: if dwz decides that it's not a good ide= a to optimize the file, it will not report an error, because we never get to write_die.=20 - the error may have to be handled in more than one location. - it may take relatively long before the error is detected. The fix for this is to have a verify phase (before or in combination with read_debug_info). Such a phase would obviously add more processing time, so= it would be good to have the user to be able to switch that on or off. --=20 You are receiving this mail because: You are on the CC list for the bug.