From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93854 invoked by alias); 6 Dec 2019 14:19:46 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 93820 invoked by uid 48); 6 Dec 2019 14:19:41 -0000 From: "vries at gcc dot gnu.org" To: dwz@sourceware.org Subject: [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii Date: Tue, 01 Jan 2019 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: dwz X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: nobody at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc everconfirmed Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2019-q4/txt/msg00120.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D25252 Tom de Vries changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |UNCONFIRMED CC| |vries at gcc dot gnu.org Ever confirmed|1 |0 --- Comment #1 from Tom de Vries --- This still exits with 0 on dwz-0.13-branch, so presumably 0.13-3 is just so= me random recent trunk version. I've bisected this on trunk to commit 48a78ec "Improve handling of running = into both low-mem and max die-limits". The commit makes the first dwz here return 1, which makes thisret 1, which makes ret 1, which gets us an exit status of 1: ... thisret =3D (low_mem_die_limit =3D=3D 0 ? 2 : dwz (file, NULL, &resa[i - optind], hardlinks ? resa : NULL, &argv[optind])); if (thisret =3D=3D 2) { multifile_mode =3D MULTIFILE_MODE_LOW_MEM; thisret =3D dwz (file, NULL, &resa[i - optind], hardlinks ? resa : NULL, &argv[optind]); } else if (resa[i - optind].res =3D=3D 0) successcount++; else if (thisret =3D=3D 1) ret =3D 1; ... Without the commit, the second dwz returns 1, which is ignored, which is a = bug, which should be fixed by this patch: ... diff --git a/dwz.c b/dwz.c index 313c317..af891ab 100644 --- a/dwz.c +++ b/dwz.c @@ -13525,7 +13525,7 @@ main (int argc, char *argv[]) } else if (resa[i - optind].res =3D=3D 0) successcount++; - else if (thisret =3D=3D 1) + if (thisret =3D=3D 1) ret =3D 1; if (hardlink && resa[i - optind].res >=3D 0 ... As for the exit status 1, that's currently the expected result when running into the max-die-limit. --=20 You are receiving this mail because: You are on the CC list for the bug.