From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-553-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 20176 invoked by alias); 17 Dec 2019 12:32:09 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <dwz.sourceware.org>
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 20148 invoked by uid 48); 17 Dec 2019 12:32:05 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25276] create_import_tree performance improvements
Date: Tue, 01 Jan 2019 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-25276-11298-clcdfVhxe6@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-25276-11298@http.sourceware.org/bugzilla/>
References: <bug-25276-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q4/txt/msg00168.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25276

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Looking at the perf data, we spend 51% of the time in dwz,=20

> Furthermore, we spent 28% here:
> ...
>   7,02 =E2=94=821481:   movb   $0x0,0x2c(%rax)
>        =E2=94=82            for (icu =3D ipu->next; icu; icu =3D icu->nex=
t)
>  28,04 =E2=94=82        mov    0x18(%rax),%rax
>   0,00 =E2=94=82        test   %rax,%rax
>   0,87 =E2=94=82      =E2=86=91 jne    1481
> ...
> which is this loop here:
> ...
>       for (icu =3D ipu->next; icu; icu =3D icu->next)
>         icu->seen =3D false;
> ...
>=20

With current master, we now spent 41% of execution time in dwz, and of that=
 41%
we spent 59% in this loop:
...
  1,39 =E2=94=822895:=E2=94=8C=E2=94=80=E2=86=92test   %rax,%rax
  0,01 =E2=94=82     =E2=94=82=E2=86=91 je     1fcd
       =E2=94=82     =E2=94=82        icu->seen =3D false;
 11,10 =E2=94=82     =E2=94=82  movb   $0x0,0x34(%rax)
       =E2=94=82     =E2=94=82      for (icu =3D ipu->next; icu; icu =3D ic=
u->next)
 47,87 =E2=94=82     =E2=94=82  mov    0x20(%rax),%rax
  0,36 =E2=94=82     =E2=94=94=E2=94=80=E2=94=80jmp    2895
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.