From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-589-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 1753 invoked by alias); 17 Jan 2020 15:47:46 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <dwz.sourceware.org>
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 1684 invoked by uid 48); 17 Jan 2020 15:47:42 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25411] New: CU referenced from PU (--odr-mode=basic
 case)
Date: Wed, 01 Jan 2020 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-25411-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2020-q1/txt/msg00027.txt

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25411

            Bug ID: 25411
           Summary: CU referenced from PU (--odr-mode=3Dbasic case)
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

When applying the assert patch from PR25398 comment 1 to master, we hit the
assert like this:
...
$ dwz cc1 -o 1 -lnone --odr --odr-mode=3Dbasic
dwz: dwz.c:10943: write_die: Assertion `IMPLIES (cu->cu_kind =3D=3D CU_PU, =
die_cu
(refd)->cu_kind =3D=3D CU_PU)' failed.
Aborted (core dumped)
...

The process of splitting the duplicate chain for odr DIEs can result in som=
e of
the DIEs not being part of any duplicate chain afterwards, and consequently=
 not
being part of a partial unit, while in fact that may be required.

Normally, in partition_dups phase 1 we decide which DIEs we want to move in=
to
partial units because it's profitable, and in partition_dups phase 2 we find
which DIEs we have to move into partial units because they are referenced by
other DIEs already in partial units.

So, if a DIE marked as referenced in phase 2 is not part of any duplicate
chain, it won't be moved to a partial unit, causing the reference from PU to
CU.

--=20
You are receiving this mail because:
You are on the CC list for the bug.