From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dwz-return-597-listarch-dwz=sourceware.org@sourceware.org>
Received: (qmail 57494 invoked by alias); 22 Jan 2020 12:57:09 -0000
Mailing-List: contact dwz-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <dwz.sourceware.org>
List-Post: <mailto:dwz@sourceware.org>
List-Help: <mailto:dwz-help@sourceware.org>
List-Subscribe: <mailto:dwz-subscribe@sourceware.org>
Sender: dwz-owner@sourceware.org
Received: (qmail 57441 invoked by uid 48); 22 Jan 2020 12:57:05 -0000
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25439] namespace DIE added to duplicate chain list
 (--odr-mode=basic)
Date: Wed, 01 Jan 2020 00:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-25439-11298-IzMui50TxU@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-25439-11298@http.sourceware.org/bugzilla/>
References: <bug-25439-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2020-q1/txt/msg00035.txt

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25439

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Starting commit 62e4949 "Fix reference from PU to CU (--odr-mode=3Dbasic)=
", we
> run into an abort in build_abbrevs_for_die with:
> ...
> $ dwz -Lnone -lnone -o 1 Checker.so.debug --odr-mode=3Dbasic
> ...
>=20
> This is a consequence of calling partition_found_dups with a die where
> die->named_namespace =3D=3D 1 during mark_singletons, the function added =
in the
> offending commit.
>=20
> This happens because a die:
> ...
>  (gdb) call dump_die (die)
>  4db7a86 O ffe1edf 0  imported_module
> ...
> has a reference to a namespace:
> ...
> (gdb) call dump_die (reft)
>  4c3e954 X 9a045343 0 llvm namespace
> ...

And this again is a consequence of something we can detect earlier:
...
@@ -6343,6 +6350,7 @@ partition_cmp (const void *p, const void *q)
 static void
 partition_found_dups (dw_die_ref die, struct obstack *vec)
 {
+  assert (die->die_ck_state =3D=3D CK_KNOWN);
   obstack_ptr_grow (vec, die);
   if (unlikely (verify_dups_p))
     verify_dups (die, true);
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.