public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25449] Factor out compilation units
Date: Wed, 01 Jan 2020 00:00:00 -0000	[thread overview]
Message-ID: <bug-25449-11298-BuGnnKdftj@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25449-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25449

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> So, the jist of this seems to be:
> - factored out partial unit: needs import
> - factored out compilation unit:
>   - prudent to import from C compilation unit (but we can have f.i. a
>     command line option to not do this, and see what breaks)

Alternatively, we can try to prove we don't need the import.  If the all the
elements in the factored out compilation unit are uniquely named in link scope,
there's no confusion about which is meant, and we don't need the import.

>   - not required from C++ compilation unit

Conversely, this may cause problems because there may be different DIEs with
the same globally unique name which are not structurally equivalent. This
happens for instance with member function templates, where a DIE in one CU
representing a named struct can have extra members representing the various
member function template instantiations in the CU, making the DIE potentially
different from other DIEs representing the same named struct in other CUs. [
Which is why we want a --odr-mode=unify option. ]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2020-01-23 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01  0:00 [Bug default/25449] New: " vries at gcc dot gnu.org
2020-01-01  0:00 ` vries at gcc dot gnu.org [this message]
2020-01-01  0:00 ` [Bug default/25449] " vries at gcc dot gnu.org
2020-01-01  0:00 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25449-11298-BuGnnKdftj@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).