[Bug default/26252] New: dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[Bug default/26252] New: dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

            Bug ID: 26252
           Summary: dwz.c:11404: write_die: Assertion `value &&
                    refdcu->cu_kind != CU_ALT' failed. #2
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: jan.kratochvil at redhat dot com
                CC: dwz at sourceware dot org
  Target Milestone: ---

With b7111689a2ccec2f57343f1051ec8f1df5e89e5c = commit 2020-02-19
getting $subject which should have been fixed by PR 25109 but it is not.

It is reproducible at least with these 233 packages:
  http://people.redhat.com/jkratoch/dwz-assert.pkglist

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Jan Kratochvil from comment #0)
> With b7111689a2ccec2f57343f1051ec8f1df5e89e5c = commit 2020-02-19
> getting $subject which should have been fixed by PR 25109 but it is not.
> 
> It is reproducible at least with these 233 packages:
>   http://people.redhat.com/jkratoch/dwz-assert.pkglist

Can you attach a reproducer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Jan Kratochvil from comment #0)
> It is reproducible at least with these 233 packages:
>   http://people.redhat.com/jkratoch/dwz-assert.pkglist

FWIW, I've tried to make a reproducer myself by building binutils, which is in
this list, but no luck.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat dot com

--- Comment #3 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
Created attachment 12782
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12782&action=edit
.tar.xz

b7111689a2ccec2f57343f1051ec8f1df5e89e5c = 2020-02-19
~/redhat/dwz-git/dwz -m dwz.debug --odr 1.debug 2.debug 
~/redhat/dwz-git/dwz: 1.debug: DWARF compression not beneficial - old size
317760 new size 317760
dwz: dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT'
failed.
Aborted (core dumped)

Although I find more a blocker for DWZ after 3+ years it still does not support
DWARF-5; and not just its part as produced by GCC but also the DWARF-5 features
produced by LLVM: PR 24726

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|dwz.c:11404: write_die:     |[odr] dwz.c:11404:
                   |Assertion `value &&         |write_die: Assertion `value
                   |refdcu->cu_kind != CU_ALT'  |&& refdcu->cu_kind !=
                   |failed. #2                  |CU_ALT' failed. #2
                 CC|                            |mark at klomp dot org

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
This only reproduces with --odr. Without things work fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Posted fix: https://sourceware.org/pipermail/dwz/2021q1/000890.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Jan Kratochvil from comment #0)
> With b7111689a2ccec2f57343f1051ec8f1df5e89e5c = commit 2020-02-19
> getting $subject which should have been fixed by PR 25109 but it is not.
> 

PR25109 is related to die_no_multifile propagation, and the problem occurs
independent of odr.

This problem is related to CK_BAD propagation, and occurs only with odr.

The two root causes are different, they just happen to trigger the same assert.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed in commit
https://sourceware.org/git/?p=dwz.git;a=commit;h=3312feb1783283cb072d094fce9e1f6255d5da63

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26252] [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != CU_ALT' failed. #2

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26252

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
*** Bug 25439 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.