From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 0296E385481C; Mon,  4 Jan 2021 08:52:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0296E385481C
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27115] FAIL:
 dwz-0.13/testsuite/dwz.tests/devel-ignore-size.sh
Date: Mon, 04 Jan 2021 08:52:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27115-11298-QbPO4RiHnR@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27115-11298@http.sourceware.org/bugzilla/>
References: <bug-27115-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2021 08:52:47 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27115

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Vitaly Chikunov from comment #6)
> Created attachment 13088 [details]
> example of dwz in/out binaries
>=20
> Attached archive with `min` is source, `1` is processed.

Comparing the size results, that looks sane:
...
$ ../../../measure/diff.sh min 1
.debug_info      red: 19.24%    1986  1604
.debug_abbrev    red: 16.19%    791  663
.debug_str       red: 0%        1726  1726
total            red: 11.33%    4503 3993
...

Looking at the created partial unit, it contains a couple of base types, li=
ke
"long unsigned int".

Using a grep, we can see that this comes from compilation units abi-note.c =
and
elf-init.c:
...
$ egrep "DW_AT_name.*(long unsigned int|\.)|Compilation" READELF.min | grep=
 -v
"long long"
  Compilation Unit @ offset 0x0:
    <20>   DW_AT_name        : ../sysdeps/x86_64/start.S
  Compilation Unit @ offset 0x2e:
    <3f>   DW_AT_name        : abi-note.c
    <63>   DW_AT_name        : long unsigned int
  Compilation Unit @ offset 0x4ff:
    <510>   DW_AT_name        : init.c
  Compilation Unit @ offset 0x53f:
    <553>   DW_AT_name        : ../sysdeps/x86_64/crti.S
  Compilation Unit @ offset 0x561:
    <572>   DW_AT_name        : min.c
  Compilation Unit @ offset 0x5b4:
    <5c5>   DW_AT_name        : min-2.c
  Compilation Unit @ offset 0x607:
    <618>   DW_AT_name        : elf-init.c
    <64f>   DW_AT_name        : long unsigned int
  Compilation Unit @ offset 0x7a0:
    <7b4>   DW_AT_name        : ../sysdeps/x86_64/crtn.S
...

So this all seems ok.

Without reverting to dwarf assembly, it's hard to create an exec with debug
info that is guaranteed to not be compressed.

So for now, the easiest fix is to detect this situation, and mark the test
unsupported:
...
diff --git a/testsuite/dwz.tests/devel-ignore-size.sh
b/testsuite/dwz.tests/devel-ignore-si
ze.sh
index 5134043..78d28a2 100644
--- a/testsuite/dwz.tests/devel-ignore-size.sh
+++ b/testsuite/dwz.tests/devel-ignore-size.sh
@@ -12,7 +12,9 @@ cnt=3D$(readelf -wi 1 \
            | grep '(DW_TAG_partial_unit' \
            | wc -l)

-[ $cnt -eq 0 ]
+if [ $cnt -ne 0 ]; then
+    exit 77
+fi

 cp $execs/min 1

...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=