From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id AFA19396ECB7; Wed, 20 Jan 2021 21:56:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFA19396ECB7
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20
Date: Wed, 20 Jan 2021 21:56:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27212-11298-0QofTe8dIy@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27212-11298@http.sourceware.org/bugzilla/>
References: <bug-27212-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2021 21:56:58 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27212

--- Comment #8 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Jakub Jelinek from comment #7)
> I understood what you meant with that dance, but as the abbrev is stored
> first the value doesn't really make it into the abbrev.  Furthermore, the
> abbrev comparison/hashing needs to include those exact values, so they
> shouldn't be modified afterwards.

O, you are right. So my worries about (and the code workarounds for) changi=
ng
an abbrev implicit_const value multiple times were unnecessary. We can do it
simply in build_abbrevs_for_die because the passed in struct abbrev_tag *t =
is a
"scratch" one setup by the caller(s) to make sure we have something to
construct the new abbrev in. Great. Then I totally agree with this patch.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=