From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id A1365398581B; Wed, 20 Jan 2021 21:15:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1365398581B From: "mark at klomp dot org" To: dwz@sourceware.org Subject: [Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20 Date: Wed, 20 Jan 2021 21:15:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: dwz X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: nobody at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 21:15:12 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27212 --- Comment #6 from Mark Wielaard --- The "dance" with having the file number only translated once and then stori= ng the negated number was to prevent translating it again when we processed the same abbrev for another DIE. I am trying to convince myself this cannot hap= pen with this patch. But am not 100% sure. If we go with this change then the write_die part can be simplified a littl= e by getting rid of the bool update variable before the first switch statement (= and setting it to true in all the cases) and just have case DW_FORM_implicit_co= nst: break; in the second switch statement. --=20 You are receiving this mail because: You are on the CC list for the bug.=